chrome/browser/media_galleries/fileapi/picasa/picasa_data_provider.cc - Issue 17101030: Media Galleries API - Picasa: Change PMP Parsing to deal with PlatformFile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/picasa/picasa_data_provider.cc

Issue 17101030: Media Galleries API - Picasa: Change PMP Parsing to deal with PlatformFile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/fileapi/picasa/picasa_album_table_reader_unittest.cc ('k') | chrome/browser/media_galleries/fileapi/picasa/pmp_column_reader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/picasa/picasa_data_provider.cc

diff --git a/chrome/browser/media_galleries/fileapi/picasa/picasa_data_provider.cc b/chrome/browser/media_galleries/fileapi/picasa/picasa_data_provider.cc

index cdeec7644ccd86386fed6d54ef875e19894b3fbd..94902714da3156a83f1d54b387e8f8dc873f87e4 100644

--- a/chrome/browser/media_galleries/fileapi/picasa/picasa_data_provider.cc

+++ b/chrome/browser/media_galleries/fileapi/picasa/picasa_data_provider.cc

@@ -89,7 +89,8 @@ void PicasaDataProvider::UniquifyNames(const std::vector<AlbumInfo>& info_list,

}

bool PicasaDataProvider::ReadData() {

- PicasaAlbumTableReader album_table_reader(database_path_);

+ PicasaAlbumTableFiles album_table_files(database_path_);

+ PicasaAlbumTableReader album_table_reader((album_table_files));

tommycli 2013/06/19 22:58:39 Need parens for most vexing parse issue.

if (!album_table_reader.Init())

return false;