Add a function to convert key system into UUID

webkit/renderer/media/crypto/key_systems_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <vector>
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 #include "webkit/renderer/media/crypto/key_systems.h"
@@ skipping 735 matching lines @@
   EXPECT_FALSE(IsSupportedKeySystemWithMediaMimeType(
       "audio/mp4", avc1_codec(), kWidevineAlpha));
   EXPECT_FALSE(IsSupportedKeySystemWithMediaMimeType(
       "audio/mp4", avc1_and_aac_codecs(), kWidevineAlpha));
 
   // Non-MP4 codec.
   EXPECT_FALSE(IsSupportedKeySystemWithMediaMimeType(
       "audio/mp4", vorbis_codec(), kWidevineAlpha));
 }
 
+#if defined(OS_ANDROID)
+TEST_F(KeySystemsTest, ConvertKeySystemToUUID) {
+  std::vector<uint8> uuid = GetUUID(kWidevineAlpha);
+  EXPECT_EQ(16u, uuid.size());

[ddorwin, 2013/06/20 22:20:15]

Do you care about the actual uuid? It seems we should maybe have at least one
value checked.

[qinmin, 2013/06/20 23:30:12]

Done.

+

[ddorwin, 2013/06/20 22:20:15]

You could break out unsupported systmes into a separate _Unrecognized test. That
has the same effect as the comment that was removed but in a better way.

[qinmin, 2013/06/20 23:30:12]

Done.

+  uuid = GetUUID(kWidevine);

[ddorwin, 2013/06/20 22:20:15]

These could all be collapsed into a single line. For example:
EXPECT_EQ(0u, GetUUID(kWidevine));

[qinmin, 2013/06/20 23:30:12]

Changed to EXPECT_TRUE(GetUUID(kWidevine).empty())

+  EXPECT_EQ(0u, uuid.size());
+  uuid = GetUUID(kClearKey);
+  EXPECT_EQ(0u, uuid.size());
+  uuid = GetUUID("");
+  EXPECT_EQ(0u, uuid.size());
+}
+#endif  // defined(OS_ANDROID)
+
 }  // namespace webkit_media