Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 17101021: Removed ReplaceResultBuilder. (Closed)

Created:
7 years, 6 months ago by Sven Panne
Modified:
7 years, 6 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Removed ReplaceResultBuilder. Most of its code was dead, and the remaining part was a simple one-liner, which is now inlined at its single call-site. R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15200

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -39 lines) Patch
M src/string.js View 2 chunks +1 line, -39 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 6 months ago (2013-06-19 08:48:39 UTC) #1
Yang
On 2013/06/19 08:48:39, Sven Panne wrote: LGTM!
7 years, 6 months ago (2013-06-19 08:49:42 UTC) #2
Sven Panne
7 years, 6 months ago (2013-06-19 09:00:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15200 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698