Avoid duplicate effort in _getElementReferenceId

Avoid duplicate effort in _getElementReferenceId

We were going to extra effort to find the compilation unit containing
[element], but it was always the immediately enclosing element.

This CL rearranges the code so that there's no duplicate effort and so
that it's clear from the flow control that the immediately enclosing
element is the compilation unit.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/371cd6efcf7924b75d6ca1cd5287f43aa0136ae7

[Paul Berry, 2016-02-18 18:26:06]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-02-18 18:27:05]

LGTM

[Paul Berry, 2016-02-18 18:37:31]

Description was changed from

==========
Avoid duplicate effort in _getElementReferenceId

We were going to extra effort to find the compilation unit containing
[element], but it was always the immediately enclosing element.

This CL rearranges the code so that there's no duplicate effort and so
that it's clear from the flow control that the immediately enclosing
element is the compilation unit.
==========

to

==========
Avoid duplicate effort in _getElementReferenceId

We were going to extra effort to find the compilation unit containing
[element], but it was always the immediately enclosing element.

This CL rearranges the code so that there's no duplicate effort and so
that it's clear from the flow control that the immediately enclosing
element is the compilation unit.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/371cd6efcf7924b75d6ca1cd5287f43aa0136ae7
==========

[Paul Berry, 2016-02-18 18:37:32]

Committed patchset #1 (id:1) manually as
371cd6efcf7924b75d6ca1cd5287f43aa0136ae7 (presubmit successful).