Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1710083007: Update libpng to 1.6.22beta (Closed)

Created:
4 years, 10 months ago by msarett
Modified:
4 years, 10 months ago
Reviewers:
scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update libpng to 1.6.22beta Intel SSE filter optimizations have been upstreamed. Let's test on the upstream version (which we can use in Android). BUG=skia:4573 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1710083007 Committed: https://skia.googlesource.com/skia/+/740668d9071b8b767ec4ca344cb31fc0773ac2d5

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Keep the skia.googlesource mirror #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -324 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M gyp/codec.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/libpng.gyp View 1 1 chunk +20 lines, -28 lines 0 comments Download
M src/codec/SkPngCodec.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
D src/codec/SkPngFilters.h View 1 chunk +0 lines, -27 lines 0 comments Download
D src/codec/SkPngFilters.cpp View 1 chunk +0 lines, -237 lines 0 comments Download
M third_party/libpng/pnglibconf.h View 3 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
msarett
4 years, 10 months ago (2016-02-19 17:03:43 UTC) #4
scroggo
https://codereview.chromium.org/1710083007/diff/20001/DEPS File DEPS (right): https://codereview.chromium.org/1710083007/diff/20001/DEPS#newcode21 DEPS:21: # FIXME: Once the 1.6.22 release is available, we ...
4 years, 10 months ago (2016-02-19 17:21:23 UTC) #6
mtklein
https://codereview.chromium.org/1710083007/diff/20001/gyp/libpng.gyp File gyp/libpng.gyp (right): https://codereview.chromium.org/1710083007/diff/20001/gyp/libpng.gyp#newcode89 gyp/libpng.gyp:89: [ '"arm" == skia_arch_type and arm_neon_optional == 1', { ...
4 years, 10 months ago (2016-02-19 17:28:30 UTC) #7
msarett
https://codereview.chromium.org/1710083007/diff/20001/DEPS File DEPS (right): https://codereview.chromium.org/1710083007/diff/20001/DEPS#newcode21 DEPS:21: # FIXME: Once the 1.6.22 release is available, we ...
4 years, 10 months ago (2016-02-19 18:36:18 UTC) #8
mtklein
lgtm!
4 years, 10 months ago (2016-02-19 18:37:35 UTC) #9
scroggo
lgtm
4 years, 10 months ago (2016-02-19 18:39:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710083007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710083007/40001
4 years, 10 months ago (2016-02-19 18:50:07 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 19:14:46 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/740668d9071b8b767ec4ca344cb31fc0773ac2d5

Powered by Google App Engine
This is Rietveld 408576698