Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1710083005: Remove old downloads UI; Material Design version is now the default. (Closed)

Created:
4 years, 10 months ago by Dan Beam
Modified:
4 years, 10 months ago
Reviewers:
asanka, sky
CC:
asanka, arv+watch_chromium.org, asvitkine+watch_chromium.org, Alexei Svitkine (slow), chromium-reviews, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove old downloads UI; Material Design version is now the default. This step removes the code and resources. Next step drops all the "Md" prefixes. R=asanka@chromium.org,asvitkine@chromium.org BUG=528484 Committed: https://crrev.com/2b4fc356ff151e0c104596bffea377d6fad40281 Cr-Commit-Position: refs/heads/master@{#376895}

Patch Set 1 #

Patch Set 2 : merge #

Total comments: 1

Patch Set 3 : remove testing/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3257 lines) Patch
M chrome/app/generated_resources.grd View 1 4 chunks +0 lines, -15 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/browser_resources.grd View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/lifetime/browser_close_manager_browsertest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/browser/resources/downloads/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/resources/downloads/compiled_resources.gyp View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/resources/downloads/compiled_resources2.gyp View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/resources/downloads/constants.html View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/resources/downloads/constants.js View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/resources/downloads/downloads.css View 1 chunk +0 lines, -163 lines 0 comments Download
D chrome/browser/resources/downloads/downloads.html View 1 chunk +0 lines, -104 lines 0 comments Download
D chrome/browser/resources/downloads/externs.js View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/resources/downloads/focus_row.js View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/resources/downloads/item_view.js View 1 chunk +0 lines, -395 lines 0 comments Download
D chrome/browser/resources/downloads/manager.js View 1 chunk +0 lines, -256 lines 0 comments Download
D chrome/browser/resources/downloads/throttled_icon_loader.html View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/resources/downloads/throttled_icon_loader.js View 1 chunk +0 lines, -61 lines 0 comments Download
M chrome/browser/resources/md_downloads/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/externs.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 3 chunks +3 lines, -8 lines 0 comments Download
D chrome/browser/ui/webui/downloads_dom_handler.h View 1 chunk +0 lines, -178 lines 0 comments Download
D chrome/browser/ui/webui/downloads_dom_handler.cc View 1 chunk +0 lines, -722 lines 0 comments Download
D chrome/browser/ui/webui/downloads_dom_handler_browsertest.cc View 1 chunk +0 lines, -330 lines 0 comments Download
D chrome/browser/ui/webui/downloads_ui.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/ui/webui/downloads_ui.cc View 1 chunk +0 lines, -136 lines 0 comments Download
D chrome/browser/ui/webui/downloads_ui_browsertest.h View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/ui/webui/downloads_ui_browsertest.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/ui/webui/downloads_ui_browsertest.js View 1 chunk +0 lines, -170 lines 0 comments Download
D chrome/browser/ui/webui/downloads_ui_browsertest_base.js View 1 chunk +0 lines, -177 lines 0 comments Download
D chrome/browser/ui/webui/downloads_ui_supervised_browsertest.h View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/ui/webui/downloads_ui_supervised_browsertest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/ui/webui/downloads_ui_supervised_browsertest.js View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/ui/webui/downloads_util.h View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/ui/webui/downloads_util.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/ui/webui/downloads_util_unittest.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 4 chunks +0 lines, -12 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/base/web_ui_browser_test_browsertest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/closure_compiler/compiled_resources.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/closure_compiler/compiled_resources2.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D ui/webui/resources/images/2x/otr_icon_standalone.png View Binary file 0 comments Download
D ui/webui/resources/images/otr_icon_standalone.png View Binary file 0 comments Download

Messages

Total messages: 17 (9 generated)
Dan Beam
+asanka for download-y stuff +asvitkine@ for testing/variations I'll add sky@ for chrome/ when y'all are ...
4 years, 10 months ago (2016-02-19 01:28:06 UTC) #4
sky
LGTM
4 years, 10 months ago (2016-02-19 20:47:08 UTC) #6
Alexei Svitkine (slow)
https://codereview.chromium.org/1710083005/diff/20001/testing/variations/fieldtrial_testing_config_chromeos.json File testing/variations/fieldtrial_testing_config_chromeos.json (left): https://codereview.chromium.org/1710083005/diff/20001/testing/variations/fieldtrial_testing_config_chromeos.json#oldcode64 testing/variations/fieldtrial_testing_config_chromeos.json:64: "MaterialDesignDownloads": [ The server-side configs still specify the trial ...
4 years, 10 months ago (2016-02-19 20:51:02 UTC) #7
Dan Beam
ok, reverted changes to testing/ for now (and moved asvitkine to CC) will still wait ...
4 years, 10 months ago (2016-02-20 00:17:42 UTC) #9
asanka
lgtm
4 years, 10 months ago (2016-02-22 22:01:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710083005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710083005/40001
4 years, 10 months ago (2016-02-23 00:36:26 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-23 01:43:36 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 01:44:32 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2b4fc356ff151e0c104596bffea377d6fad40281
Cr-Commit-Position: refs/heads/master@{#376895}

Powered by Google App Engine
This is Rietveld 408576698