Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1710083002: Move SkTDStack.h to src/animator. (Closed)

Created:
4 years, 10 months ago by bungeman-skia
Modified:
4 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move SkTDStack.h to src/animator. This file is only used by animator and may or may not be sane. Move the file from include/core to src/animator since no one else is using it. TBR=reed Make it go away! Committed: https://skia.googlesource.com/skia/+/bc1cebbd2b25cbc43b2ab76809d959b5185b29e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -110 lines) Patch
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D include/core/SkTDStack.h View 1 chunk +0 lines, -110 lines 0 comments Download
A + src/animator/SkTDStack.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710083002/1
4 years, 10 months ago (2016-02-18 17:48:19 UTC) #5
bungeman-skia
4 years, 10 months ago (2016-02-18 17:50:49 UTC) #6
mtklein
lgtm
4 years, 10 months ago (2016-02-18 18:09:09 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-18 18:12:44 UTC) #9
reed1
lgtm
4 years, 10 months ago (2016-02-18 18:27:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710083002/1
4 years, 10 months ago (2016-02-18 18:59:59 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 19:01:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bc1cebbd2b25cbc43b2ab76809d959b5185b29e2

Powered by Google App Engine
This is Rietveld 408576698