Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1710073002: PPC: More simplification and unification of frame handling (Closed)

Created:
4 years, 10 months ago by MTBrandyberry
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: More simplification and unification of frame handling Port 55071954bcd65be6782388624b986e9751899377 Original commit message: Frame slots indexes numbers are used more consistently for computation in both TurboFan and Crankshaft. Specifically, Crankshaft now uses frame slot indexes in LChunk, removing the need for some special-case maths when building the deoptimization translation table. R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/6cd74a7efebbd3e5d279dd90b01dbba21bef3017 Cr-Commit-Position: refs/heads/master@{#34126}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.h View 2 chunks +8 lines, -2 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 6 chunks +4 lines, -10 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
4 years, 10 months ago (2016-02-18 17:45:18 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710073002/1
4 years, 10 months ago (2016-02-18 17:45:34 UTC) #3
JoranSiu
On 2016/02/18 17:45:34, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 10 months ago (2016-02-18 18:01:20 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-18 18:26:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710073002/1
4 years, 10 months ago (2016-02-18 18:32:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 18:34:41 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 18:34:54 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6cd74a7efebbd3e5d279dd90b01dbba21bef3017
Cr-Commit-Position: refs/heads/master@{#34126}

Powered by Google App Engine
This is Rietveld 408576698