Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1710033002: Add scrollDelta units to GestureScrollEnd. (Closed)

Created:
4 years, 10 months ago by dtapuska
Modified:
4 years, 10 months ago
Reviewers:
tdresser, Rick Byers
CC:
chromium-reviews, blink-reviews, darin-cc_chromium.org, dglazkov+blink, jam, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master_wheel_passive_listeners_3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add scrollDelta units to GestureScrollEnd. It is necessary to know if the scroll end gesture is from a high precision touchpad or not; add a field. BUG=568183 Committed: https://crrev.com/8d8fc0060bfa538f96453196be1d9c9989b14ea9 Cr-Commit-Position: refs/heads/master@{#376260}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add precise pixels unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -39 lines) Patch
M content/browser/renderer_host/input/mouse_wheel_event_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue.cc View 3 chunks +11 lines, -5 lines 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc View 1 8 chunks +62 lines, -33 lines 0 comments Download
M third_party/WebKit/public/web/WebInputEvent.h View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
dtapuska
4 years, 10 months ago (2016-02-18 15:53:26 UTC) #3
tdresser
LGTM https://codereview.chromium.org/1710033002/diff/1/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc File content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc (right): https://codereview.chromium.org/1710033002/diff/1/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc#newcode180 content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc:180: EXPECT_EQ(WebGestureEvent::Pixels, Should we have a test which expects ...
4 years, 10 months ago (2016-02-18 16:00:46 UTC) #4
dtapuska
https://codereview.chromium.org/1710033002/diff/1/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc File content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc (right): https://codereview.chromium.org/1710033002/diff/1/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc#newcode180 content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc:180: EXPECT_EQ(WebGestureEvent::Pixels, On 2016/02/18 16:00:46, tdresser wrote: > Should we ...
4 years, 10 months ago (2016-02-18 16:16:44 UTC) #5
tdresser
Thanks!
4 years, 10 months ago (2016-02-18 16:20:38 UTC) #6
Rick Byers
LGTM
4 years, 10 months ago (2016-02-18 19:13:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710033002/20001
4 years, 10 months ago (2016-02-18 19:18:05 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-18 21:12:34 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 21:13:54 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d8fc0060bfa538f96453196be1d9c9989b14ea9
Cr-Commit-Position: refs/heads/master@{#376260}

Powered by Google App Engine
This is Rietveld 408576698