Extract Chrome-specific code from NativeAppWindowViews

Extract Chrome-specific code from NativeAppWindowViews

* Extract Chrome code into ChromeNativeAppWindowViews
* Introduce apps/ui/views/native_app_window_view.h/cc
* Add stubs to NativeAppWindowViews so it can be used in tests and in
  app_shell.
* Move ShapedAppWindowTargeter to apps/ui/views

This is part 1 of 2 CLs to allow app_shell to create a NativeAppWindow
and show a Hello world app.

BUG=343174
TEST=existing browser_tests, specifically PlatformApp*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252766

[James Cook, 2014-02-20 22:41:31]

benwells, PTAL.  I'll send you the part 2 patch shortly.

https://codereview.chromium.org/171003004/diff/50001/chrome/browser/ui/views/...
File chrome/browser/ui/views/apps/native_app_window_views.h (right):

https://codereview.chromium.org/171003004/diff/50001/chrome/browser/ui/views/...
chrome/browser/ui/views/apps/native_app_window_views.h:5: #ifndef
CHROME_BROWSER_UI_VIEWS_APPS_NATIVE_APP_WINDOW_VIEWS_H_
I intentionally didn't rename this file (yet) so that Reitveld will show you
good diffs for both apps/ui/views/native_app_window_views.cc and this file.  If
this patch looks good I'll do the rename in a separate step.

https://codereview.chromium.org/171003004/diff/50001/chrome/browser/ui/views/...
File chrome/browser/ui/views/apps/native_app_window_views_win.h (right):

https://codereview.chromium.org/171003004/diff/50001/chrome/browser/ui/views/...
chrome/browser/ui/views/apps/native_app_window_views_win.h:6: #define
CHROME_BROWSER_UI_VIEWS_APPS_NATIVE_APP_WINDOW_VIEWS_WIN_H_
Another intentional non-rename.  I'll rename this one and the last one at the
same time.

[benwells, 2014-02-21 07:12:38]

this lgtm. Thanks for doing it :)

https://codereview.chromium.org/171003004/diff/50001/chrome/browser/ui/views/...
File chrome/browser/ui/views/apps/native_app_window_views.h (right):

https://codereview.chromium.org/171003004/diff/50001/chrome/browser/ui/views/...
chrome/browser/ui/views/apps/native_app_window_views.h:72: bool
ShouldUseChromeStyleFrame() const;
Note: I'm about to commit a change which changes the name of this function.

[James Cook, 2014-02-21 23:50:42]

Ben, rebasing on top of the custom-frame-color and easy-reshape-targeter code
wasn't trivial -- to make the diffs clearer I renamed the new class to
BaseNativeAppWindowViews and kept the existing NativeAppWindowViews name in
Chrome.

I'll file a bug to change the base class name to NativeAppWindowViews and name
the Chrome version ChromeNativeAppWindowViews.

[James Cook, 2014-02-21 23:51:46]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-02-21 23:52:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/171003004/300001

[commit-bot: I haz the power, 2014-02-22 01:29:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/171003004/300001

[commit-bot: I haz the power, 2014-02-22 08:00:26]

Change committed as 252766