Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1710013002: Cleanup HTMLMediaElement to use anonymous namespace. (Closed)

Created:
4 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 10 months ago
Reviewers:
philipj_slow
CC:
chromium-reviews, nessy, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews, vcarbune.chromium, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup HTMLMediaElement to use anonymous namespace. This is removing the static soup and move the #define/typedef at the right place. BUG=None R=philipj@opera.com Committed: https://crrev.com/41d204a7ce91d117c2a8691bfa7c8abd1d84a57b Cr-Commit-Position: refs/heads/master@{#376372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -27 lines) Patch
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 7 chunks +31 lines, -27 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710013002/1
4 years, 10 months ago (2016-02-18 14:20:53 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-18 15:29:10 UTC) #4
philipj_slow
lgtm
4 years, 10 months ago (2016-02-19 03:51:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710013002/1
4 years, 10 months ago (2016-02-19 03:53:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 04:07:32 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 04:08:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41d204a7ce91d117c2a8691bfa7c8abd1d84a57b
Cr-Commit-Position: refs/heads/master@{#376372}

Powered by Google App Engine
This is Rietveld 408576698