third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp - Issue 1709963002: [css-align] New CSS Value 'normal' for Self Alignment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp

Issue 1709963002: [css-align] New CSS Value 'normal' for Self Alignment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Getting back the FullScreen fix, missed during the rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutFullScreen.h ('k') | third_party/WebKit/Source/core/layout/LayoutGrid.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp b/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp

index f17fb6a68560f7d0f397222ea2aa9f93939f0995..29558f0f3150ac292eb730938d51eccc405048b3 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp

@@ -105,6 +105,7 @@ void LayoutFullScreen::updateStyle()

fullscreenStyle->setDisplay(FLEX);

fullscreenStyle->setJustifyContentPosition(ContentPositionCenter);

+ // TODO (lajava): Since the FullScrenn layout object is anonymous, its Default Alignment (align-items) value can't be used to resolve its children Self Alignment 'auto' values.

fullscreenStyle->setAlignItemsPosition(ItemPositionCenter);

fullscreenStyle->setFlexDirection(FlowColumn);

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutFullScreen.h ('k') | third_party/WebKit/Source/core/layout/LayoutGrid.h » ('j') | no next file with comments »