third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h - Issue 1709963002: [css-align] New CSS Value 'normal' for Self Alignment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 1709963002: [css-align] New CSS Value 'normal' for Self Alignment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Getting back the FullScreen fix, missed during the rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt ('k') | third_party/WebKit/Source/core/css/CSSProperties.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

index dd8e963354bda5ff8036228abca6213577972601..73562a95f5273fea27b499b120052559002545fd 100644

--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

@@ -4373,7 +4373,12 @@ template<> inline CSSPrimitiveValue::CSSPrimitiveValue(ItemPosition itemPosition

init(UnitType::ValueID);

switch (itemPosition) {

case ItemPositionAuto:

- m_value.valueID = CSSValueAuto;

+ // The 'auto' values might have been already resolved.

+ NOTREACHED();

+ m_value.valueID = CSSValueNormal;

+ break;

+ case ItemPositionNormal:

+ m_value.valueID = CSSValueNormal;

break;

case ItemPositionStretch:

m_value.valueID = CSSValueStretch;

@@ -4419,6 +4424,8 @@ template<> inline ItemPosition CSSPrimitiveValue::convertTo() const

switch (m_value.valueID) {

case CSSValueAuto:

return ItemPositionAuto;

+ case CSSValueNormal:

+ return ItemPositionNormal;

case CSSValueStretch:

return ItemPositionStretch;

case CSSValueBaseline: