Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: third_party/WebKit/LayoutTests/fast/repaint/align-self-change-keeping-geometry-grid.html

Issue 1709963002: [css-align] New CSS Value 'normal' for Self Alignment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Getting back the FullScreen fix, missed during the rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/repaint/align-self-change-keeping-geometry-grid.html
diff --git a/third_party/WebKit/LayoutTests/fast/repaint/align-self-change-keeping-geometry-grid.html b/third_party/WebKit/LayoutTests/fast/repaint/align-self-change-keeping-geometry-grid.html
index c7d878cc541e1a4c994d57a7e8e6008470317f9a..f15b1705e02efe2b5b14045023f6481c41266a71 100644
--- a/third_party/WebKit/LayoutTests/fast/repaint/align-self-change-keeping-geometry-grid.html
+++ b/third_party/WebKit/LayoutTests/fast/repaint/align-self-change-keeping-geometry-grid.html
@@ -2,7 +2,8 @@
<script src="resources/text-based-repaint.js"></script>
<script>
function repaintTest() {
- document.getElementsByClassName('item')[0].style.alignSelf = 'stretch';
+ document.getElementsByClassName('item1')[0].style.alignSelf = 'stretch';
+ document.getElementsByClassName('item2')[0].style.alignSelf = 'stretch';
}
onload = runRepaintAndPixelTest;
</script>
@@ -12,21 +13,27 @@ body {
}
#container {
display: grid;
- grid: 300px / 100px;
+ align-items: start;
+ grid: 300px / 100px 100px;
width: 200px;
height: 300px;
background-color: red;
}
-.item {
+.item1 {
grid-row: 1;
grid-column: 1;
- align-self: start;
+ height: 300px;
+ background-color: green;
+}
+.item2 {
+ grid-row: 1;
+ grid-column: 2;
+ height: 300px;
background-color: green;
}
</style>
<p style="height: 20px">There should be no invalidations because align-self style change causes no visual change.</p>
<div id="container">
- <div class="item">
- <div style="height: 300px"></div>
- </div>
+ <div id="item1" class="item1"></div>
+ <div id="item2" class="item2"></div>
</div>

Powered by Google App Engine
This is Rietveld 408576698