Chromium Code Reviews| Index: third_party/WebKit/LayoutTests/fast/alignment/parse-align-items.html |
| diff --git a/third_party/WebKit/LayoutTests/fast/alignment/parse-align-items.html b/third_party/WebKit/LayoutTests/fast/alignment/parse-align-items.html |
| index 99a083fd03a5c31963cc1af4b48b5e675155b78b..1e1511dcadb7e2777def949d1ff2466b2a0520a5 100644 |
| --- a/third_party/WebKit/LayoutTests/fast/alignment/parse-align-items.html |
| +++ b/third_party/WebKit/LayoutTests/fast/alignment/parse-align-items.html |
| @@ -176,7 +176,7 @@ debug(""); |
| debug("Test initial value of align-items through JS"); |
| element = document.createElement("div"); |
| document.body.appendChild(element); |
| -shouldBe("getComputedStyle(element, '').getPropertyValue('align-items')", "'start'"); |
| +shouldBe("getComputedStyle(element, '').getPropertyValue('align-items')", "'normal'"); |
| debug(""); |
| debug("Test getting and setting align-items through JS"); |
| @@ -200,16 +200,18 @@ checkValues(element, "alignItems", "align-items", "center", "center"); |
| element.style.alignItems = "self-start"; |
| checkValues(element, "alignItems", "align-items", "self-start", "self-start"); |
| +<!-- The 'auto' value is no valid for the align-items property. --> |
|
Timothy Loh
2016/03/07 05:58:31
err this is javascript, comments are // :-)
typo
jfernandez
2016/03/14 09:29:29
Done.
|
| +element.style.alignItems = "end"; |
|
Timothy Loh
2016/03/07 05:58:31
better to set to "" which clears it IMO
jfernandez
2016/03/14 09:29:29
Done.
|
| element.style.alignItems = "auto"; |
| -checkValues(element, "alignItems", "align-items", "auto", "start"); |
| +checkValues(element, "alignItems", "align-items", "end", "end"); |
| element.style.display = "flex"; |
| element.style.alignItems = "auto"; |
| -checkValues(element, "alignItems", "align-items", "auto", "stretch"); |
| +checkValues(element, "alignItems", "align-items", "end", "end"); |
| element.style.display = "grid"; |
| element.style.alignItems = "auto"; |
| -checkValues(element, "alignItems", "align-items", "auto", "stretch"); |
| +checkValues(element, "alignItems", "align-items", "end", "end"); |
| element.style.alignItems = "self-end"; |
| checkValues(element, "alignItems", "align-items", "self-end", "self-end"); |
| @@ -219,6 +221,7 @@ debug("Test bad combinations of align-items"); |
| element = document.createElement("div"); |
| document.body.appendChild(element); |
| +checkBadValues(element, "alignItems", "align-items", "auto"); |
| checkBadValues(element, "alignItems", "align-items", "unsafe auto"); |
| checkBadValues(element, "alignItems", "align-items", "auto safe"); |
| checkBadValues(element, "alignItems", "align-items", "auto left"); |
| @@ -247,17 +250,17 @@ checkBadValues(element, "alignItems", "align-items", "legacy left right"); |
| debug(""); |
| debug("Test the value 'initial'"); |
| element.style.display = ""; |
| -checkInitialValues(element, "alignItems", "align-items", "center", "start"); |
| +checkInitialValues(element, "alignItems", "align-items", "center", "normal"); |
| debug(""); |
| debug("Test the value 'initial' for grid containers"); |
| element.style.display = "grid"; |
| -checkInitialValues(element, "alignItems", "align-items", "left safe", "stretch"); |
| +checkInitialValues(element, "alignItems", "align-items", "left safe", "normal"); |
| debug(""); |
| debug("Test the value 'initial' for flex containers"); |
| element.style.display = "flex"; |
| -checkInitialValues(element, "alignItems", "align-items", "right unsafe", "stretch"); |
| +checkInitialValues(element, "alignItems", "align-items", "right unsafe", "normal"); |
| debug(""); |
| debug("Test the value 'inherit'"); |