Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1709963002: [css-align] New CSS Value 'normal' for Self Alignment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed repaint tests. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index c95355321073624881a6c982cb9ec15b59b40077..3e368eedc64a24f984c5de33686579133ff28e03 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -2360,13 +2360,12 @@ LayoutUnit LayoutBox::computeLogicalWidthUsing(SizeType widthType, const Length&
static bool columnFlexItemHasStretchAlignment(const LayoutObject* flexitem)
{
- LayoutObject* parent = flexitem->parent();
// auto margins mean we don't stretch. Note that this function will only be used for
// widths, so we don't have to check marginBefore/marginAfter.
- ASSERT(parent->style()->isColumnFlexDirection());
+ DCHECK(flexitem->parent()->style()->isColumnFlexDirection());
if (flexitem->style()->marginStart().isAuto() || flexitem->style()->marginEnd().isAuto())
return false;
- return flexitem->style()->alignSelfPosition() == ItemPositionStretch || (flexitem->style()->alignSelfPosition() == ItemPositionAuto && parent->style()->alignItemsPosition() == ItemPositionStretch);
+ return flexitem->styleRef().resolvedAlignSelf(ItemPositionStretch).position() == ItemPositionStretch;
}
static bool isStretchingColumnFlexItem(const LayoutObject* flexitem)
@@ -2394,8 +2393,8 @@ bool LayoutBox::hasStretchedLogicalWidth() const
return false;
}
if (cb->isHorizontalWritingMode() != isHorizontalWritingMode())
- return ComputedStyle::resolveAlignment(cb->styleRef(), style, ItemPositionStretch) == ItemPositionStretch;
- return ComputedStyle::resolveJustification(cb->styleRef(), style, ItemPositionStretch) == ItemPositionStretch;
+ return style.resolvedAlignSelf(ItemPositionStretch).position() == ItemPositionStretch;
+ return style.resolvedJustifySelf(ItemPositionStretch).position() == ItemPositionStretch;
}
bool LayoutBox::sizesLogicalWidthToFitContent(const Length& logicalWidth) const

Powered by Google App Engine
This is Rietveld 408576698