Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: third_party/WebKit/LayoutTests/fast/alignment/parse-justify-self.html

Issue 1709963002: [css-align] New CSS Value 'normal' for Self Alignment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Unskipped some repaint tests and rebaselined. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/alignment/parse-justify-self.html
diff --git a/third_party/WebKit/LayoutTests/fast/alignment/parse-justify-self.html b/third_party/WebKit/LayoutTests/fast/alignment/parse-justify-self.html
index d80089b69c383465d233f864a1a1a5021d5aa208..87edfda777ba6adcc5e9287ca52a7f64a895d267 100644
--- a/third_party/WebKit/LayoutTests/fast/alignment/parse-justify-self.html
+++ b/third_party/WebKit/LayoutTests/fast/alignment/parse-justify-self.html
@@ -175,7 +175,7 @@ debug("");
debug("Test initial value of justify-self through JS");
element = document.createElement("div");
document.body.appendChild(element);
-shouldBe("getComputedStyle(element, '').getPropertyValue('justify-self')", "'start'");
+shouldBe("getComputedStyle(element, '').getPropertyValue('justify-self')", "'normal'");
debug("");
debug("Test getting and setting justify-self through JS");
@@ -202,20 +202,25 @@ element.style.justifySelf = "self-start";
checkValues(element, "justifySelf", "justify-self", "self-start", "self-start");
element.style.justifySelf = "auto";
-checkValues(element, "justifySelf", "justify-self", "auto", "start");
+checkValues(element, "justifySelf", "justify-self", "auto", "normal");
container.style.display = "flex";
element.style.justifySelf = "auto";
-checkValues(element, "justifySelf", "justify-self", "auto", "stretch");
+checkValues(element, "justifySelf", "justify-self", "auto", "normal");
container.style.display = "grid";
element.style.justifySelf = "auto";
-checkValues(element, "justifySelf", "justify-self", "auto", "stretch");
+checkValues(element, "justifySelf", "justify-self", "auto", "normal");
element.style.justifySelf = "self-end";
checkValues(element, "justifySelf", "justify-self", "self-end", "self-end");
debug("");
+debug("Test 'auto' value resolution for the root node");
+document.documentElement.style.justifySelf = "auto";
+checkValues(document.documentElement, "justifySelf", "justify-self", "auto", "normal");
+
+debug("");
debug("Test bad combinations of justify-self");
container = document.createElement("div");
element = document.createElement("div");
@@ -250,35 +255,35 @@ checkBadValues(element, "justifySelf", "justify-self", "legacy left right");
debug("");
debug("Test the value 'initial'");
container.style.display = "";
-checkInitialValues(element, "justifySelf", "justify-self", "center", "start");
+checkInitialValues(element, "justifySelf", "justify-self", "center", "normal");
debug("");
debug("Test the value 'initial' for grid containers");
container.style.display = "grid";
-checkInitialValues(element, "justifySelf", "justify-self", "left safe", "stretch");
+checkInitialValues(element, "justifySelf", "justify-self", "left safe", "normal");
debug("");
debug("Test the value 'initial' for flex containers");
container.style.display = "flex";
-checkInitialValues(element, "justifySelf", "justify-self", "right unsafe", "stretch");
+checkInitialValues(element, "justifySelf", "justify-self", "right unsafe", "normal");
debug("");
debug("Test the value 'initial' for positioned elements");
container.style.display = "";
element.style.position = "absolute";
-checkInitialValues(element, "justifySelf", "justify-self", "left", "stretch");
+checkInitialValues(element, "justifySelf", "justify-self", "left", "normal");
debug("");
debug("Test the value 'initial' for positioned elements in grid containers");
container.style.display = "grid";
element.style.position = "absolute";
-checkInitialValues(element, "justifySelf", "justify-self", "right", "stretch");
+checkInitialValues(element, "justifySelf", "justify-self", "right", "normal");
debug("");
debug("Test the value 'initial' for positioned elements in grid containers");
container.style.display = "flex";
element.style.position = "absolute";
-checkInitialValues(element, "justifySelf", "justify-self", "end", "stretch");
+checkInitialValues(element, "justifySelf", "justify-self", "end", "normal");
debug("");
debug("Test the value 'inherit'");

Powered by Google App Engine
This is Rietveld 408576698