Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2077)

Unified Diff: third_party/WebKit/LayoutTests/fast/alignment/parse-align-self.html

Issue 1709963002: [css-align] New CSS Value 'normal' for Self Alignment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Unskipped some repaint tests and rebaselined. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/alignment/parse-align-self.html
diff --git a/third_party/WebKit/LayoutTests/fast/alignment/parse-align-self.html b/third_party/WebKit/LayoutTests/fast/alignment/parse-align-self.html
index 5cca1b968d1f302313ba63653d68a9f4d7f357b6..3531ca548758f001bec4b6657e19069ea8f5235c 100644
--- a/third_party/WebKit/LayoutTests/fast/alignment/parse-align-self.html
+++ b/third_party/WebKit/LayoutTests/fast/alignment/parse-align-self.html
@@ -175,7 +175,7 @@ debug("");
debug("Test initial value of align-self through JS");
element = document.createElement("div");
document.body.appendChild(element);
-shouldBe("getComputedStyle(element, '').getPropertyValue('align-self')", "'start'");
+shouldBe("getComputedStyle(element, '').getPropertyValue('align-self')", "'normal'");
debug("");
debug("Test getting and setting align-self through JS");
@@ -202,20 +202,25 @@ element.style.alignSelf = "self-start";
checkValues(element, "alignSelf", "align-self", "self-start", "self-start");
element.style.alignSelf = "auto";
-checkValues(element, "alignSelf", "align-self", "auto", "start");
+checkValues(element, "alignSelf", "align-self", "auto", "normal");
container.style.display = "flex";
element.style.alignSelf = "auto";
-checkValues(element, "alignSelf", "align-self", "auto", "stretch");
+checkValues(element, "alignSelf", "align-self", "auto", "normal");
container.style.display = "grid";
element.style.alignSelf = "auto";
-checkValues(element, "alignSelf", "align-self", "auto", "stretch");
+checkValues(element, "alignSelf", "align-self", "auto", "normal");
element.style.alignSelf = "self-end";
checkValues(element, "alignSelf", "align-self", "self-end", "self-end");
debug("");
+debug("Test 'auto' value resolution for the root node");
+document.documentElement.style.alignSelf = "auto";
+checkValues(document.documentElement, "alignSelf", "align-self", "auto", "normal");
+
+debug("");
debug("Test bad combinations of align-self");
container = document.createElement("div");
element = document.createElement("div");
@@ -250,35 +255,35 @@ checkBadValues(element, "alignSelf", "align-self", "legacy left right");
debug("");
debug("Test the value 'initial'");
container.style.display = "";
-checkInitialValues(element, "alignSelf", "align-self", "center", "start");
+checkInitialValues(element, "alignSelf", "align-self", "center", "normal");
debug("");
debug("Test the value 'initial' for grid containers");
container.style.display = "grid";
-checkInitialValues(element, "alignSelf", "align-self", "left safe", "stretch");
+checkInitialValues(element, "alignSelf", "align-self", "left safe", "normal");
debug("");
debug("Test the value 'initial' for flex containers");
container.style.display = "flex";
-checkInitialValues(element, "alignSelf", "align-self", "right unsafe", "stretch");
+checkInitialValues(element, "alignSelf", "align-self", "right unsafe", "normal");
debug("");
debug("Test the value 'initial' for positioned elements");
container.style.display = "";
element.style.position = "absolute";
-checkInitialValues(element, "alignSelf", "align-self", "left", "start");
+checkInitialValues(element, "alignSelf", "align-self", "left", "normal");
debug("");
debug("Test the value 'initial' for positioned elements in grid containers");
container.style.display = "grid";
element.style.position = "absolute";
-checkInitialValues(element, "alignSelf", "align-self", "right", "stretch");
+checkInitialValues(element, "alignSelf", "align-self", "right", "normal");
debug("");
debug("Test the value 'initial' for positioned elements in grid containers");
container.style.display = "flex";
element.style.position = "absolute";
-checkInitialValues(element, "alignSelf", "align-self", "end", "stretch");
+checkInitialValues(element, "alignSelf", "align-self", "end", "normal");
debug("");
debug("Test the value 'inherit'");

Powered by Google App Engine
This is Rietveld 408576698