Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: third_party/WebKit/LayoutTests/fast/alignment/parse-align-items.html

Issue 1709963002: [css-align] New CSS Value 'normal' for Self Alignment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Unskipped some repaint tests and rebaselined. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/alignment/parse-align-items.html
diff --git a/third_party/WebKit/LayoutTests/fast/alignment/parse-align-items.html b/third_party/WebKit/LayoutTests/fast/alignment/parse-align-items.html
index 99a083fd03a5c31963cc1af4b48b5e675155b78b..b8bb7f4ee996fe1a2f4f3757c4f7490f411bcccb 100644
--- a/third_party/WebKit/LayoutTests/fast/alignment/parse-align-items.html
+++ b/third_party/WebKit/LayoutTests/fast/alignment/parse-align-items.html
@@ -176,7 +176,7 @@ debug("");
debug("Test initial value of align-items through JS");
element = document.createElement("div");
document.body.appendChild(element);
-shouldBe("getComputedStyle(element, '').getPropertyValue('align-items')", "'start'");
+shouldBe("getComputedStyle(element, '').getPropertyValue('align-items')", "'normal'");
debug("");
debug("Test getting and setting align-items through JS");
@@ -200,16 +200,18 @@ checkValues(element, "alignItems", "align-items", "center", "center");
element.style.alignItems = "self-start";
checkValues(element, "alignItems", "align-items", "self-start", "self-start");
+// The 'auto' value is not valid for the align-items property.
+element.style.alignItems = "";
element.style.alignItems = "auto";
-checkValues(element, "alignItems", "align-items", "auto", "start");
+checkValues(element, "alignItems", "align-items", "", "normal");
element.style.display = "flex";
element.style.alignItems = "auto";
-checkValues(element, "alignItems", "align-items", "auto", "stretch");
+checkValues(element, "alignItems", "align-items", "", "normal");
element.style.display = "grid";
element.style.alignItems = "auto";
-checkValues(element, "alignItems", "align-items", "auto", "stretch");
+checkValues(element, "alignItems", "align-items", "", "normal");
element.style.alignItems = "self-end";
checkValues(element, "alignItems", "align-items", "self-end", "self-end");
@@ -219,6 +221,7 @@ debug("Test bad combinations of align-items");
element = document.createElement("div");
document.body.appendChild(element);
+checkBadValues(element, "alignItems", "align-items", "auto");
checkBadValues(element, "alignItems", "align-items", "unsafe auto");
checkBadValues(element, "alignItems", "align-items", "auto safe");
checkBadValues(element, "alignItems", "align-items", "auto left");
@@ -247,17 +250,17 @@ checkBadValues(element, "alignItems", "align-items", "legacy left right");
debug("");
debug("Test the value 'initial'");
element.style.display = "";
-checkInitialValues(element, "alignItems", "align-items", "center", "start");
+checkInitialValues(element, "alignItems", "align-items", "center", "normal");
debug("");
debug("Test the value 'initial' for grid containers");
element.style.display = "grid";
-checkInitialValues(element, "alignItems", "align-items", "left safe", "stretch");
+checkInitialValues(element, "alignItems", "align-items", "left safe", "normal");
debug("");
debug("Test the value 'initial' for flex containers");
element.style.display = "flex";
-checkInitialValues(element, "alignItems", "align-items", "right unsafe", "stretch");
+checkInitialValues(element, "alignItems", "align-items", "right unsafe", "normal");
debug("");
debug("Test the value 'inherit'");

Powered by Google App Engine
This is Rietveld 408576698