Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1709943002: Revert of SafeBrowsing: DatabaseManager owns the V4GetHashProtocolManager (Closed)

Created:
4 years, 10 months ago by henrika (OOO until Aug 14)
Modified:
4 years, 10 months ago
CC:
chromium-reviews, grt+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of SafeBrowsing: DatabaseManager owns the V4GetHashProtocolManager (patchset #6 id:100001 of https://codereview.chromium.org/1700943003/ ) Reason for revert: Speculative revert as Chrome sheriff. I suspect that this CL causes tons of tests on Mac to fail. See e.g. https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/19690 Callstacks in all failing tests contains references to SafeBrowsing. 1 libbase.dylib 0x00000001195efbc3 _ZN4base5debug10StackTraceC1Ev + 35 2 sync_integration_tests 0x000000010a77225a _ZN4base5debug11LeakTrackerI29SystemURLRequestContextGetterEC2Ev + 58 3 sync_integration_tests 0x000000010a757783 _ZN4base5debug11LeakTrackerI29SystemURLRequestContextGetterEC1Ev + 35 4 sync_integration_tests 0x000000010a757739 _ZN29SystemURLRequestContextGetterC2EP8IOThread + 105 5 sync_integration_tests 0x000000010a7577db _ZN29SystemURLRequestContextGetterC1EP8IOThread + 43 6 sync_integration_tests 0x000000010a75c9a6 _ZN8IOThread24InitSystemRequestContextEv + 246 7 sync_integration_tests 0x000000010a75c866 _ZN8IOThread33system_url_request_context_getterEv + 358 8 sync_integration_tests 0x000000010a9b7cae _ZN18BrowserProcessImpl22system_request_contextEv + 270 9 sync_integration_tests 0x000000010b1c0e55 _ZN13safe_browsing19SafeBrowsingService10InitializeEv + 101 10 sync_integration_tests 0x000000010a9bc17b _ZN18BrowserProcessImpl25CreateSafeBrowsingServiceEv + 331 11 sync_integration_tests 0x000000010a9bbfe3 _ZN18BrowserProcessImpl21safe_browsing_serviceEv + 275 12 sync_integration_tests 0x000000010a8acf61 _ZN36ChromeResourceDispatcherHostDelegateC2Ev + 177 13 sync_integration_tests 0x000000010a8ad1d3 _ZN36ChromeResourceDispatcherHostDelegateC1Ev + 35 14 sync_integration_tests 0x000000010a9bcda5 _ZN18BrowserProcessImpl29ResourceDispatcherHostCreatedEv + 117 15 sync_integration_tests 0x000000010a6141c0 _ZN26ChromeContentBrowserClient29ResourceDispatcherHostCreatedEv + 320 16 libcontent.dylib 0x00000001212ba928 _ZN7content26ResourceDispatcherHostImplC2Ev + 1320 17 libcontent.dylib 0x00000001212baf63 _ZN7content26ResourceDispatcherHostImplC1Ev + 35 Original issue's description: > SafeBrowsing: DatabaseManager owns the V4GetHashProtocolManager > > BUG=543161, 561867 > > Committed: https://crrev.com/95bba9fad50442a9ce7ae4fbcc50d1d845d5d399 > Cr-Commit-Position: refs/heads/master@{#376088} TBR=nparker@chromium.org,vakh@chromium.org,kcarattini@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=543161, 561867 Committed: https://crrev.com/8a7a2d7a721542025da871c789fe858f3bde1211 Cr-Commit-Position: refs/heads/master@{#376131}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -137 lines) Patch
M chrome/browser/safe_browsing/local_database_manager.h View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/safe_browsing/local_database_manager.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 5 chunks +23 lines, -47 lines 0 comments Download
M components/safe_browsing_db/BUILD.gn View 2 chunks +1 line, -6 lines 0 comments Download
M components/safe_browsing_db/database_manager.h View 2 chunks +1 line, -18 lines 0 comments Download
M components/safe_browsing_db/database_manager.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M components/safe_browsing_db/remote_database_manager.h View 1 chunk +1 line, -12 lines 0 comments Download
M components/safe_browsing_db/remote_database_manager.cc View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
henrika (OOO until Aug 14)
Created Revert of SafeBrowsing: DatabaseManager owns the V4GetHashProtocolManager
4 years, 10 months ago (2016-02-18 09:48:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709943002/1
4 years, 10 months ago (2016-02-18 09:48:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 09:49:45 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 09:51:00 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8a7a2d7a721542025da871c789fe858f3bde1211
Cr-Commit-Position: refs/heads/master@{#376131}

Powered by Google App Engine
This is Rietveld 408576698