Issue 17099012: Use mutex instead of busy wait when installing optimized function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17099012: Use mutex instead of busy wait when installing optimized function. (Closed)

Created:
7 years, 6 months ago by Yang

Modified:
7 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use mutex instead of busy wait when installing optimized function. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15262

Patch Set 2 : fixed #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
M	src/optimizing-compiler-thread.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/optimizing-compiler-thread.cc	View	1	2 chunks	+8 lines, -5 lines	0 comments	Download
M	src/runtime.cc	View		1 chunk	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

https://codereview.chromium.org/17099012/diff/1/src/optimizing-compiler-thread.cc File src/optimizing-compiler-thread.cc (right): https://codereview.chromium.org/17099012/diff/1/src/optimizing-compiler-thread.cc#newcode92 src/optimizing-compiler-thread.cc:92: // Use a mutex to make sure that functions ...

7 years, 6 months ago (2013-06-21 08:35:10 UTC) #2

Yang

On 2013/06/21 08:35:10, Jakob wrote: > https://codereview.chromium.org/17099012/diff/1/src/optimizing-compiler-thread.cc > File src/optimizing-compiler-thread.cc (right): > > https://codereview.chromium.org/17099012/diff/1/src/optimizing-compiler-thread.cc#newcode92 > ...

7 years, 6 months ago (2013-06-21 08:36:32 UTC) #3

Yang

7 years, 6 months ago (2013-06-21 08:38:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r15262 (presubmit successful).

Expand Messages | Collapse Messages

Issue 17099012: Use mutex instead of busy wait when installing optimized function. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fixed #

Messages