Issue 17099008: Dead code elimination must not delete HArgumentsObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17099008: Dead code elimination must not delete HArgumentsObject (Closed)

Created:
7 years, 6 months ago by Jakob Kummerow

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Dead code elimination must not delete HArgumentsObject BUG=chromium:249894 Closing in favor of https://codereview.chromium.org/16938009/.

Patch Set 1 #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/hydrogen-instructions.h	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

https://codereview.chromium.org/17099008/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/17099008/diff/1/src/hydrogen-instructions.h#newcode3236 src/hydrogen-instructions.h:3236: virtual bool IsDeletable() const { return false; } DBC: ...

7 years, 6 months ago (2013-06-16 13:33:55 UTC) #1

Jakob Kummerow

7 years, 6 months ago (2013-06-17 11:09:11 UTC) #2

Message was sent while issue was closed.

On 2013/06/16 13:33:55, Sven Panne wrote:
> https://codereview.chromium.org/17099008/diff/1/src/hydrogen-instructions.h
> File src/hydrogen-instructions.h (right):
> 
>
https://codereview.chromium.org/17099008/diff/1/src/hydrogen-instructions.h#n...
> src/hydrogen-instructions.h:3236: virtual bool IsDeletable() const { return
> false; }
> DBC: Just remove the whole line, 'false' is the (safe) default, anyway...

Good point; but Michael has a better fix anyway (preserving deletability of
HArgumentsObject). Closing this issue.

Expand Messages | Collapse Messages