ui/aura/root_window_host_x11.cc - Issue 17099003: Use primary display as hangout/gtalk broadcast window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/aura/root_window_host_x11.cc

Issue 17099003: Use primary display as hangout/gtalk broadcast window (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/aura/root_window_host_x11.cc

diff --git a/ui/aura/root_window_host_x11.cc b/ui/aura/root_window_host_x11.cc

index 9089183c5e234b0045b3500cc2f775e43ec9e270..1ea470ad57602854ff39a3852985cd986289a482 100644

--- a/ui/aura/root_window_host_x11.cc

+++ b/ui/aura/root_window_host_x11.cc

@@ -418,9 +418,11 @@ RootWindowHostX11::RootWindowHostX11(const gfx::Rect& bounds)

// crbug.com/120229 - set the window title so gtalk can find the primary root

// window to broadcast.

// TODO(jhorwich) Remove this once Chrome supports window-based broadcasting.

+ /*

static int root_window_number = 0;

std::string name = base::StringPrintf("aura_root_%d", root_window_number++);

XStoreName(xdisplay_, xwindow_, name.c_str());

+ */

Josh Horwich 2013/06/14 22:44:03 Why not just remove this code and the above commen

oshima 2013/06/14 23:10:01 Doh, I thought I did, but looks like I didn't save

XRRSelectInput(xdisplay_, x_root_window_,

RRScreenChangeNotifyMask | RROutputChangeNotifyMask);

Env::GetInstance()->AddObserver(this);