Use primary display as hangout/gtalk broadcast window

ash/display/display_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/display/display_controller.h"
 
 #include "ash/display/display_info.h"
 #include "ash/display/display_manager.h"
 #include "ash/launcher/launcher.h"
 #include "ash/screen_ash.h"
 #include "ash/shelf/shelf_widget.h"
 #include "ash/shell.h"
 #include "ash/test/ash_test_base.h"
 #include "ash/test/cursor_manager_test_api.h"
 #include "ui/aura/env.h"
 #include "ui/aura/root_window.h"
 #include "ui/aura/test/event_generator.h"
 #include "ui/aura/window_tracker.h"
 #include "ui/base/events/event_handler.h"
 #include "ui/gfx/display.h"
 #include "ui/gfx/screen.h"
 #include "ui/views/widget/widget.h"
 
+#if defined(USE_X11)
+#include "ui/base/x/x11_util.h"
+#include <X11/Xlib.h>
+#undef RootWindow
+#endif
+
 namespace ash {
 namespace test {
 namespace {
 
 const char kDesktopBackgroundView[] = "DesktopBackgroundView";
 
 class TestObserver : public DisplayController::Observer {
  public:
   TestObserver() : changing_count_(0), changed_count_(0) {
     Shell::GetInstance()->display_controller()->AddObserver(this);
@@ skipping 892 matching lines @@
   generator.MoveMouseToInHost(599, 0);
   EXPECT_EQ("299,449", event_handler.GetLocationAndReset());
   generator.MoveMouseToInHost(599, 399);
   EXPECT_EQ("0,449", event_handler.GetLocationAndReset());
   generator.MoveMouseToInHost(0, 399);
   EXPECT_EQ("0,0", event_handler.GetLocationAndReset());
 
   Shell::GetInstance()->RemovePreTargetHandler(&event_handler);
 }
 
+void GetPrimaryAndSeconary(aura::RootWindow** primary,
+                           aura::RootWindow** secondary) {
+  *primary = Shell::GetPrimaryRootWindow();
+  Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
+  *secondary = root_windows[0] == *primary ? root_windows[1] : root_windows[0];

[Josh Horwich, 2013/06/14 22:44:03]

I know that right now the function will only be invoked when there are two
windows, but shouldn't we set *secondary to NULL if the root window list is one
element long (e.g. only one root window)?

I suppose if we do this, we could use it for the last (single display) test case
in XWindowNameForRootWindow and EXPECT_EQ(NULL, secondary); there.

[oshima, 2013/06/14 23:10:01]

For single display case, we should just use Shell::GetPrimaryDisplay().
There is already tests for multi displays scenarios, so the above case would be
a dup.

+}
+
+std::string GetXWindowName(aura::RootWindow* window) {
+  char* name = NULL;
+  XFetchName(ui::GetXDisplay(), window->GetAcceleratedWidget(), &name);
+  // ASSERT_TRUE(!!name);

[oshima, 2013/06/14 23:10:01]

I forgot to remove this as well. Removed.

+  return std::string(name);
+}

[oshima, 2013/06/14 23:10:01]

I also moved this to anonymous namespace.

+
+#if defined(USE_X11)
+TEST_F(DisplayControllerTest, XWidowNameForRootWindow) {
+  EXPECT_EQ("aura_root_0", GetXWindowName(Shell::GetPrimaryRootWindow()));
+
+  // Multiple display.
+  UpdateDisplay("200x200,300x300");
+  aura::RootWindow* primary, *secondary;
+  GetPrimaryAndSeconary(&primary, &secondary);
+  EXPECT_EQ("aura_root_0", GetXWindowName(primary));
+  EXPECT_EQ("aura_root_x", GetXWindowName(secondary));
+
+  // Swap primary.
+  Shell::GetInstance()->display_controller()->SwapPrimaryDisplay();
+  GetPrimaryAndSeconary(&primary, &secondary);
+  EXPECT_EQ("aura_root_0", GetXWindowName(primary));
+  EXPECT_EQ("aura_root_x", GetXWindowName(secondary));

[Josh Horwich, 2013/06/14 22:44:03]

Would it make sense to save the pointers from before the SwapPrimaryDisplay
call, and verify the formerly-primary is now "aura_root_x" and the
formerly-secondary is now "aura_root_0", in addition to this test where we
verify the swap changes the names?

[oshima, 2013/06/14 23:10:01]

Swapping display actually doesn't change the root windows (but it's
implementation details from this test's point of view).
This is just to make sure that window name wasn't swapped somehow.
I did change so that it resets primary/secondary to make sure it doesn't simply
use old values.

+
+  // Switching back to single display.
+  UpdateDisplay("300x400");
+  EXPECT_EQ("aura_root_0", GetXWindowName(Shell::GetPrimaryRootWindow()));
+}
+#endif
+
 }  // namespace test
 }  // namespace ash