Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1709893002: [wasm] names for wasm stubs (Closed)

Created:
4 years, 10 months ago by Mircea Trofin
Modified:
4 years, 10 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Names for wasm stubs. Synthetic names for wasm-to-js functions, for debug scenarios. BUG= Committed: https://crrev.com/5a92a1709c547920920adf05feaef518a101d573 Cr-Commit-Position: refs/heads/master@{#34124}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
M src/compiler/wasm-compiler.cc View 1 2 2 chunks +40 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Mircea Trofin
4 years, 10 months ago (2016-02-18 05:58:12 UTC) #3
titzer
lgtm with comment https://codereview.chromium.org/1709893002/diff/1/src/compiler/wasm-compiler.cc File src/compiler/wasm-compiler.cc (right): https://codereview.chromium.org/1709893002/diff/1/src/compiler/wasm-compiler.cc#newcode2091 src/compiler/wasm-compiler.cc:2091: RecordFunctionCompilation(Logger::FUNCTION_TAG, &info, "wasm-to-js", index, Use the ...
4 years, 10 months ago (2016-02-18 08:52:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709893002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709893002/40001
4 years, 10 months ago (2016-02-18 16:20:20 UTC) #7
Mircea Trofin
https://codereview.chromium.org/1709893002/diff/1/src/compiler/wasm-compiler.cc File src/compiler/wasm-compiler.cc (right): https://codereview.chromium.org/1709893002/diff/1/src/compiler/wasm-compiler.cc#newcode2091 src/compiler/wasm-compiler.cc:2091: RecordFunctionCompilation(Logger::FUNCTION_TAG, &info, "wasm-to-js", index, On 2016/02/18 08:52:18, titzer wrote: ...
4 years, 10 months ago (2016-02-18 16:20:28 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-18 16:51:51 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 16:52:43 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5a92a1709c547920920adf05feaef518a101d573
Cr-Commit-Position: refs/heads/master@{#34124}

Powered by Google App Engine
This is Rietveld 408576698