Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: src/profiler/cpu-profiler.cc

Issue 1709873002: Do not record CPU profile samples when stack collection is failed. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/profiler/profile-generator.cc » ('j') | src/profiler/profile-generator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profiler/cpu-profiler.cc
diff --git a/src/profiler/cpu-profiler.cc b/src/profiler/cpu-profiler.cc
index b6c7945797bc702cb647c5de58195f90ff6ae967..5252b9363a718380c36695224ca94f8dbce71da7 100644
--- a/src/profiler/cpu-profiler.cc
+++ b/src/profiler/cpu-profiler.cc
@@ -114,7 +114,9 @@ ProfilerEventsProcessor::SampleProcessingResult
if (record->order != last_processed_code_event_id_) {
return FoundSampleForNextCodeEvent;
}
- generator_->RecordTickSample(record->sample);
+ if (record->sample.pc) {
titzer 2016/02/19 09:28:37 Will this tick just be discarded? Is there a bucke
alph 2016/02/19 16:24:29 It is just discarded, so effectively it adds to al
titzer 2016/02/19 16:36:33 As long as the missing samples go somewhere, so as
alph 2016/02/19 17:54:22 Agree.
+ generator_->RecordTickSample(record->sample);
+ }
ticks_buffer_.Remove();
return OneSampleProcessed;
}
« no previous file with comments | « no previous file | src/profiler/profile-generator.cc » ('j') | src/profiler/profile-generator.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698