Do not record CPU profile samples when stack collection is failed.

src/profiler/profile-generator.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/profiler/profile-generator.h"
 
 #include "src/ast/scopeinfo.h"
 #include "src/debug/debug.h"
 #include "src/deoptimizer.h"
 #include "src/global-handles.h"
@@ skipping 618 matching lines @@
           // In the latter case we know the caller for sure but in the
           // former case we don't so we simply replace the frame with
           // 'unresolved' entry.
           if (sample.top_frame_type == StackFrame::JAVA_SCRIPT) {
             *entry++ = unresolved_entry_;
           }
         }
       }
     }
 
-    for (const Address* stack_pos = sample.stack,
-           *stack_end = stack_pos + sample.frames_count;
-         stack_pos != stack_end;
-         ++stack_pos) {
+    for (const Address *stack_pos = sample.stack,

[titzer, 2016/02/19 09:28:37]

Formatting artifact? git cl format should have fixed this.

[alph, 2016/02/19 16:24:29]

So it did.
I hope you don't think I reformatted that manually? ;-)

[titzer, 2016/02/19 16:36:33]

I just asked because it looks backwards to our normal formatting of the star
sticking to the left (i.e. to the type).

+                       *stack_end = stack_pos + sample.frames_count;
+         stack_pos != stack_end; ++stack_pos) {
       *entry = code_map_.FindEntry(*stack_pos);
 
       // Skip unresolved frames (e.g. internal frame) and get source line of
       // the first JS caller.
       if (src_line_not_found && *entry) {
         int pc_offset =
             static_cast<int>(*stack_pos - (*entry)->instruction_start());
         src_line = (*entry)->GetSourceLine(pc_offset);
         if (src_line == v8::CpuProfileNode::kNoLineNumberInfo) {
           src_line = (*entry)->line_number();
@@ skipping 37 matching lines @@
     case EXTERNAL:
       return program_entry_;
     case IDLE:
       return idle_entry_;
     default: return NULL;
   }
 }
 
 }  // namespace internal
 }  // namespace v8