Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: media/cast/test/end2end_unittest.cc

Issue 1709863002: Add Cast PLI support on sender side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/cast/sender/video_sender.cc ('K') | « media/cast/test/cast_benchmarks.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/test/end2end_unittest.cc
diff --git a/media/cast/test/end2end_unittest.cc b/media/cast/test/end2end_unittest.cc
index 7145ba369a3a9868427ce91042aa783e3da2f062..c003616325bb5f3bca32aa8f3480ff232a3f044e 100644
--- a/media/cast/test/end2end_unittest.cc
+++ b/media/cast/test/end2end_unittest.cc
@@ -1275,5 +1275,44 @@ TEST_F(End2EndTest, TestSetPlayoutDelay) {
EXPECT_LT(jump, 120u);
}
+namespace {
+
+void OnEncodedVideoFrame(scoped_ptr<EncodedFrame> encoded_frame) {
+ const uint32_t frame_id = encoded_frame->frame_id;
+ if ((frame_id == 0) || (frame_id == 3))
+ EXPECT_EQ(encoded_frame->dependency, EncodedFrame::KEY);
+ else
+ EXPECT_EQ(encoded_frame->dependency, EncodedFrame::DEPENDENT);
+}
+
+} // namespace
+
+TEST_F(End2EndTest, TestPliGeneratingKeyFrames) {
miu 2016/02/29 23:00:45 IMO, we don't need this extra test here. These en
xjz 2016/03/01 01:14:27 Removed this test.
+ Configure(CODEC_VIDEO_VP8, CODEC_AUDIO_PCM16);
+ Create();
+
+ // Enqueue request of 5 frames from the encoder.
+ for (int i = 0; i < 5; ++i) {
+ cast_receiver_->RequestEncodedVideoFrame(base::Bind(&OnEncodedVideoFrame));
+ }
+ // Encode 3 frames.
+ for (int frame_id = 0; frame_id < 3; ++frame_id) {
+ SendVideoFrame(frame_id, testing_clock_.NowTicks());
+ RunTasks(33);
+ }
+ // Send Pli from receiver.
+ RtcpPliMessage pli_message(video_sender_config_.ssrc);
+ transport_receiver_->SendRtcpFromRtpReceiver(
+ video_sender_config_.receiver_ssrc, video_sender_config_.ssrc,
+ media::cast::RtcpTimeData(), nullptr, &pli_message, base::TimeDelta(),
+ nullptr, nullptr);
+ // Encode 2 other frames.
+ for (int frame_id = 3; frame_id < 5; ++frame_id) {
+ SendVideoFrame(frame_id, testing_clock_.NowTicks() +
+ base::TimeDelta::FromMilliseconds(500));
+ RunTasks(33);
+ }
+}
+
} // namespace cast
} // namespace media
« media/cast/sender/video_sender.cc ('K') | « media/cast/test/cast_benchmarks.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698