Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: media/cast/net/rtcp/rtcp_utility.cc

Issue 1709863002: Add Cast PLI support on sender side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/net/rtcp/rtcp_utility.cc
diff --git a/media/cast/net/rtcp/rtcp_utility.cc b/media/cast/net/rtcp/rtcp_utility.cc
index 74af3a04fb45ab8b3998c185d80cafdcda4e49a4..e50a186b9f6fb9f0dd85d56036218e8bb21b407f 100644
--- a/media/cast/net/rtcp/rtcp_utility.cc
+++ b/media/cast/net/rtcp/rtcp_utility.cc
@@ -33,7 +33,8 @@ RtcpParser::RtcpParser(uint32_t local_ssrc, uint32_t remote_ssrc)
has_sender_report_(false),
has_last_report_(false),
has_cast_message_(false),
- has_receiver_reference_time_report_(false) {}
+ has_receiver_reference_time_report_(false),
+ received_picture_loss_indicator_(false) {}
RtcpParser::~RtcpParser() {}
@@ -45,6 +46,7 @@ bool RtcpParser::Parse(base::BigEndianReader* reader) {
receiver_log_.clear();
has_cast_message_ = false;
has_receiver_reference_time_report_ = false;
+ received_picture_loss_indicator_ = false;
while (reader->remaining()) {
RtcpCommonHeader header;
@@ -56,6 +58,13 @@ bool RtcpParser::Parse(base::BigEndianReader* reader) {
return false;
base::BigEndianReader chunk(tmp.data(), tmp.size());
+ // Check for receiving PLI.
miu 2016/02/26 23:36:07 Please move this to the case kPacketTypePayloadSpe
xjz 2016/02/27 05:53:32 Done.
+ if ((header.IC == 1) && (header.P == 0) &&
miu 2016/02/26 23:36:07 OOC, why do we check header.P? Doesn't seem to ma
xjz 2016/02/27 05:53:32 Removed.
+ (header.PT == kPacketTypePayloadSpecific) &&
+ (header.length_in_octets == 12)) {
+ return ParsePli(&chunk, header);
+ }
+
switch (header.PT) {
case kPacketTypeSenderReport:
if (!ParseSR(&chunk, header))
@@ -184,6 +193,24 @@ bool RtcpParser::ParseReportBlock(base::BigEndianReader* reader) {
return true;
}
+bool RtcpParser::ParsePli(base::BigEndianReader* reader,
+ const RtcpCommonHeader& header) {
+ uint32_t receiver_ssrc, sender_ssrc;
+ if (!reader->ReadU32(&receiver_ssrc))
+ return false;
+ // Ignore this Rtcp if the receiver ssrc does not match.
+ if (receiver_ssrc != remote_ssrc_)
+ return true;
+ if (!reader->ReadU32(&sender_ssrc))
+ return false;
+ // Ignore this Rtcp if the sender ssrc does not match.
miu 2016/02/26 23:36:07 nit: extra space
xjz 2016/02/27 05:53:32 Done.
+ if (sender_ssrc != local_ssrc_)
+ return true;
+
+ received_picture_loss_indicator_ = true;
+ return true;
+}
+
bool RtcpParser::ParseApplicationDefined(base::BigEndianReader* reader,
const RtcpCommonHeader& header) {
uint32_t sender_ssrc;

Powered by Google App Engine
This is Rietveld 408576698