Correctly filter duplicate variable references in styles.

Correctly filter duplicate variable references in styles.

This patch introduces a HashSet to track custom property additions
when constructing PropertySets, so that duplicates are excluded.
This already happens for standard properties, but is tracked for
them by a BitArray.

Committed: https://crrev.com/a8b3cb0b38cab9abdb57e161989bbdd558581a31
Cr-Commit-Position: refs/heads/master@{#376134}

[shans, 2016-02-18 01:14:21]

shans@chromium.org changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2016-02-18 01:19:33]

https://codereview.chromium.org/1709843002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/css/variables/resolve-duplicate-variables-in-style-attribute.html
(right):

https://codereview.chromium.org/1709843002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/css/variables/resolve-duplicate-variables-in-style-attribute.html:8:
console.log(testElem.style.length);
assert_equals(..., 1)?

https://codereview.chromium.org/1709843002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp (right):

https://codereview.chromium.org/1709843002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp:73: if
(property.id() != CSSPropertyVariable) {
uhhh... I think it's better to negate this condition. Will make it easier in the
future if we need to add anything else here (e.g. @apply)

[shans, 2016-02-18 04:28:59]

https://codereview.chromium.org/1709843002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/css/variables/resolve-duplicate-variables-in-style-attribute.html
(right):

https://codereview.chromium.org/1709843002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/css/variables/resolve-duplicate-variables-in-style-attribute.html:8:
console.log(testElem.style.length);
On 2016/02/18 at 01:19:32, Timothy Loh wrote:
> assert_equals(..., 1)?

Done.

https://codereview.chromium.org/1709843002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp (right):

https://codereview.chromium.org/1709843002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp:73: if
(property.id() != CSSPropertyVariable) {
On 2016/02/18 at 01:19:32, Timothy Loh wrote:
> uhhh... I think it's better to negate this condition. Will make it easier in
the future if we need to add anything else here (e.g. @apply)

Done.

[shans, 2016-02-18 04:48:17]

The CQ bit was checked by shans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-18 04:49:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1709843002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1709843002/20001

[Timothy Loh, 2016-02-18 05:15:46]

lgtm

[commit-bot: I haz the power, 2016-02-18 06:18:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 06:18:32]

Dry run: This issue passed the CQ dry run.

[shans, 2016-02-18 10:12:34]

The CQ bit was checked by shans@chromium.org

[commit-bot: I haz the power, 2016-02-18 10:13:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1709843002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1709843002/20001

[commit-bot: I haz the power, 2016-02-18 10:17:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-18 10:18:29]

Description was changed from

==========
Correctly filter duplicate variable references in styles.

This patch introduces a HashSet to track custom property additions
when constructing PropertySets, so that duplicates are excluded.
This already happens for standard properties, but is tracked for
them by a BitArray.
==========

to

==========
Correctly filter duplicate variable references in styles.

This patch introduces a HashSet to track custom property additions
when constructing PropertySets, so that duplicates are excluded.
This already happens for standard properties, but is tracked for
them by a BitArray.

Committed: https://crrev.com/a8b3cb0b38cab9abdb57e161989bbdd558581a31
Cr-Commit-Position: refs/heads/master@{#376134}
==========

[commit-bot: I haz the power, 2016-02-18 10:18:29]

Patchset 2 (id:??) landed as
https://crrev.com/a8b3cb0b38cab9abdb57e161989bbdd558581a31
Cr-Commit-Position: refs/heads/master@{#376134}