Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1709783002: Fix LNK1210 when linking blink_core.dll in gn builds. (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke, scottmg
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix LNK1210 when linking blink_core.dll in gn builds. This matches the 'LinkIncremental': '1' for webcore_shared in core.gyp ('1' means 'off' for LinkIncremental). Patch dictated by scottmg over a noisy channel; typing and denoising by me. BUG=587530 R=scottmg@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/432d2962b984956cfa90653d8d5a082f40703667

Patch Set 1 #

Patch Set 2 : win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Nico
The alternative would be to tweak default_large_module_incremental_linking, but ruining everything for just one target doesn't ...
4 years, 10 months ago (2016-02-17 21:54:23 UTC) #3
scottmg
lgtm
4 years, 10 months ago (2016-02-17 21:58:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709783002/20001
4 years, 10 months ago (2016-02-17 22:04:20 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/432d2962b984956cfa90653d8d5a082f40703667 Cr-Commit-Position: refs/heads/master@{#376000}
4 years, 10 months ago (2016-02-17 22:16:25 UTC) #8
Nico
Committed patchset #2 (id:20001) manually as 432d2962b984956cfa90653d8d5a082f40703667 (presubmit successful).
4 years, 10 months ago (2016-02-17 22:17:02 UTC) #10
sky
4 years, 10 months ago (2016-02-17 22:32:44 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1704213002/ by sky@chromium.org.

The reason for reverting is: scottmg says we should revert the patch that caused
the issue. Which means I have to revert this one first. So, doing that..

Powered by Google App Engine
This is Rietveld 408576698