Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1709753002: Mark existing image filter entry points that will be going away with Deprecated (Closed)

Created:
4 years, 10 months ago by robertphillips
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment #

Patch Set 3 : Update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -253 lines) Patch
M gm/imagefiltersbase.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M include/core/SkImageFilter.h View 1 2 6 chunks +13 lines, -12 lines 0 comments Download
M include/effects/SkBlurImageFilter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M include/effects/SkColorFilterImageFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkComposeImageFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkDisplacementMapEffect.h View 2 chunks +6 lines, -6 lines 0 comments Download
M include/effects/SkDropShadowImageFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkImageSource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkMagnifierImageFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkMatrixConvolutionImageFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkMergeImageFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkMorphologyImageFilter.h View 2 chunks +8 lines, -8 lines 0 comments Download
M include/effects/SkOffsetImageFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkPaintImageFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkPictureImageFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkTestImageFilters.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkTileImageFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkXfermodeImageFilter.h View 1 chunk +7 lines, -7 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkImageFilter.cpp View 8 chunks +21 lines, -20 lines 0 comments Download
M src/core/SkLocalMatrixImageFilter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkLocalMatrixImageFilter.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M src/core/SkMatrixImageFilter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/core/SkMatrixImageFilter.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 2 chunks +8 lines, -7 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M src/effects/SkComposeImageFilter.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 4 chunks +15 lines, -14 lines 0 comments Download
M src/effects/SkDropShadowImageFilter.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M src/effects/SkImageSource.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 2 6 chunks +24 lines, -24 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 2 chunks +8 lines, -7 lines 0 comments Download
M src/effects/SkMergeImageFilter.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 5 chunks +18 lines, -14 lines 0 comments Download
M src/effects/SkOffsetImageFilter.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/effects/SkPaintImageFilter.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M src/effects/SkPictureImageFilter.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/effects/SkTestImageFilters.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkTileImageFilter.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 3 chunks +14 lines, -14 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageFilterTest.cpp View 7 chunks +25 lines, -12 lines 0 comments Download
M tests/PDFPrimitivesTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
robertphillips
4 years, 10 months ago (2016-02-17 20:55:20 UTC) #4
Stephen White
LGTM w/nit https://codereview.chromium.org/1709753002/diff/1/include/core/SkImageFilter.h File include/core/SkImageFilter.h (right): https://codereview.chromium.org/1709753002/diff/1/include/core/SkImageFilter.h#newcode236 include/core/SkImageFilter.h:236: * be added to the "offset" parameter ...
4 years, 10 months ago (2016-02-17 21:15:50 UTC) #6
robertphillips
https://codereview.chromium.org/1709753002/diff/1/include/core/SkImageFilter.h File include/core/SkImageFilter.h (right): https://codereview.chromium.org/1709753002/diff/1/include/core/SkImageFilter.h#newcode236 include/core/SkImageFilter.h:236: * be added to the "offset" parameter in mageImageDeprecated ...
4 years, 10 months ago (2016-02-17 21:18:22 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709753002/20001
4 years, 10 months ago (2016-02-17 21:18:42 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-Arm7-Debug-iOS-Trybot/builds/380)
4 years, 10 months ago (2016-02-17 21:19:49 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709753002/40001
4 years, 10 months ago (2016-02-17 21:23:22 UTC) #14
robertphillips
4 years, 10 months ago (2016-02-17 21:24:55 UTC) #15
bsalomon
On 2016/02/17 21:24:55, robertphillips wrote: lgtm
4 years, 10 months ago (2016-02-17 21:35:08 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 21:54:27 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709753002/40001
4 years, 10 months ago (2016-02-17 21:55:25 UTC) #21
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 21:57:20 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/48e78468f5f6b900d476e616bdb1ba457c8f0b2a

Powered by Google App Engine
This is Rietveld 408576698