Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 1709723002: Remove ClassElementImpl.withClauseRange. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove ClassElementImpl.withClauseRange. It is not used anywhere within analyzer, and it is not part of analyzer's public API. R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d5b4a72c5ab13761f4cc65a0981b70466eef29a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Paul Berry
4 years, 10 months ago (2016-02-17 20:22:32 UTC) #2
Brian Wilkerson
LGTM, but Konstantin might know a reason to leave it.
4 years, 10 months ago (2016-02-17 20:33:30 UTC) #4
scheglov
LGTM We don't use it anymore.
4 years, 10 months ago (2016-02-17 20:41:41 UTC) #5
Paul Berry
4 years, 10 months ago (2016-02-17 21:19:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d5b4a72c5ab13761f4cc65a0981b70466eef29a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698