Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: base/task_scheduler/priority_queue.cc

Issue 1709713002: TaskScheduler [4/9] Priority Queue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@s_2_sequence_and_task
Patch Set: self review Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/task_scheduler/priority_queue.h"
6
7 #include <utility>
8
9 #include "base/logging.h"
10
11 namespace base {
12 namespace internal {
13
14 PriorityQueue::SequenceAndSortKey::SequenceAndSortKey()
15 : sort_key(TaskPriority::LOWEST, TimeTicks()) {}
16
17 PriorityQueue::SequenceAndSortKey::SequenceAndSortKey(
18 scoped_refptr<Sequence> sequence,
19 const SequenceSortKey& sort_key)
20 : sequence(std::move(sequence)), sort_key(sort_key) {}
21
22 PriorityQueue::SequenceAndSortKey::~SequenceAndSortKey() = default;
23
24 PriorityQueue::Transaction::Transaction(PriorityQueue* outer_queue)
25 : outer_queue_(outer_queue),
26 auto_lock_(new AutoSchedulerLock(outer_queue_->container_lock_)) {
27 DCHECK(CalledOnValidThread());
28 }
29
30 PriorityQueue::Transaction::~Transaction() {
31 DCHECK(CalledOnValidThread());
32
33 // Run the sequence insertion callback once for each Sequence that was
34 // inserted in the PriorityQueue during the lifetime of this Transaction.
35 // Perform this outside the scope of PriorityQueue's lock to avoid imposing an
36 // unnecessary lock dependency on |sequence_inserted_callback_|'s destination.
37 auto_lock_.reset();
38 for (size_t i = 0; i < num_pushed_sequences_; ++i)
39 outer_queue_->sequence_inserted_callback_.Run();
40 }
41
42 void PriorityQueue::Transaction::Push(
43 scoped_ptr<SequenceAndSortKey> sequence_and_sort_key) {
44 DCHECK(CalledOnValidThread());
45 DCHECK(!sequence_and_sort_key->is_null());
46
47 outer_queue_->container_.push(std::move(sequence_and_sort_key));
48 ++num_pushed_sequences_;
49 }
50
51 const PriorityQueue::SequenceAndSortKey& PriorityQueue::Transaction::Peek()
52 const {
53 DCHECK(CalledOnValidThread());
54
55 if (outer_queue_->container_.empty())
56 return outer_queue_->empty_sequence_and_sort_key_;
danakj 2016/03/18 20:24:05 Maybe consider an IsEmpty() instead of returning e
fdoray 2016/03/18 21:22:18 Done.
57
58 return *outer_queue_->container_.top();
59 }
60
61 void PriorityQueue::Transaction::Pop() {
62 DCHECK(CalledOnValidThread());
63 DCHECK(!outer_queue_->container_.empty());
64 outer_queue_->container_.pop();
65 }
66
67 PriorityQueue::PriorityQueue(const Closure& sequence_inserted_callback)
68 : sequence_inserted_callback_(sequence_inserted_callback) {
69 DCHECK(!sequence_inserted_callback_.is_null());
70 }
71
72 PriorityQueue::PriorityQueue(const Closure& sequence_inserted_callback,
73 const PriorityQueue* predecessor_priority_queue)
74 : container_lock_(&predecessor_priority_queue->container_lock_),
75 sequence_inserted_callback_(sequence_inserted_callback) {
76 DCHECK(!sequence_inserted_callback_.is_null());
77 DCHECK(predecessor_priority_queue);
78 }
79
80 PriorityQueue::~PriorityQueue() = default;
81
82 scoped_ptr<PriorityQueue::Transaction> PriorityQueue::BeginTransaction() {
83 return make_scoped_ptr(new Transaction(this));
84 }
85
86 } // namespace internal
87 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698