Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1709663002: Check _localVariableInfo initialized in VariableResolverVisitor. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check _localVariableInfo initialized in VariableResolverVisitor. VariableResolverVisitor initializes _localVariableInfo when visiting executable declarations, but may theoretically need to access it from anywhere inside a function body. This CL adds assertions to make sure that we don't miss a case where _localVariableInfo needs to be initialized. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/cc3aa3caa61e852c49b71bbe03f504dac021e91e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-17 18:35:42 UTC) #2
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-17 18:38:47 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-17 18:44:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cc3aa3caa61e852c49b71bbe03f504dac021e91e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698