[wasm] Add support for import section.

[wasm] Add support for import section.

This CL introduces an import section that names functions to be imported
as well as a CallImport bytecode to call imports from this table.

R=binji@chromium.org,bradnelson@chromium.org
LOG=Y
BUG=chromium:575167
Committed: https://crrev.com/915ae08dd5598208d6eea727ef9478a442aba290
Cr-Commit-Position: refs/heads/master@{#34157}

[bradnelson, 2016-02-19 06:43:57]

lgtm

https://codereview.chromium.org/1709653002/diff/20001/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/1709653002/diff/20001/src/wasm/wasm-module.cc...
src/wasm/wasm-module.cc:309: thrower.Error("FFI function #%d:%s is not a
JSFunction.", index, cstr);
This will fix things crashing if a proxy object is passed correct? Update commit
message?

https://codereview.chromium.org/1709653002/diff/20001/src/wasm/wasm-module.h
File src/wasm/wasm-module.h (right):

https://codereview.chromium.org/1709653002/diff/20001/src/wasm/wasm-module.h#...
src/wasm/wasm-module.h:39: static const int kMaxModuleSectionCode = 6;
Does this need to get bumped, or is it even used?

[titzer, 2016-02-19 11:53:47]

https://codereview.chromium.org/1709653002/diff/20001/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/1709653002/diff/20001/src/wasm/wasm-module.cc...
src/wasm/wasm-module.cc:309: thrower.Error("FFI function #%d:%s is not a
JSFunction.", index, cstr);
On 2016/02/19 06:43:57, bradnelson wrote:
> This will fix things crashing if a proxy object is passed correct? Update
commit
> message?

It's the same as the code before, just factored into a utility. I'll ad a
testcase for proxies on a follow up CL.

https://codereview.chromium.org/1709653002/diff/20001/src/wasm/wasm-module.h
File src/wasm/wasm-module.h (right):

https://codereview.chromium.org/1709653002/diff/20001/src/wasm/wasm-module.h#...
src/wasm/wasm-module.h:39: static const int kMaxModuleSectionCode = 6;
On 2016/02/19 06:43:57, bradnelson wrote:
> Does this need to get bumped, or is it even used?

Good catch. It was used for checking that each section only occurs once. Since
it wasn't updated, sections larger than 6 weren't being checked correctly.

[titzer, 2016-02-19 14:56:09]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-02-19 14:56:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@chromium.org
Link to the patchset: https://codereview.chromium.org/1709653002/#ps60001
(title: "delete the import_code vector")

[commit-bot: I haz the power, 2016-02-19 14:56:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1709653002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1709653002/60001

[commit-bot: I haz the power, 2016-02-19 14:58:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-19 14:58:46]

Description was changed from

==========
[wasm] Add support for import section.

This CL introduces an import section that names functions to be imported
as well as a CallImport bytecode to call imports from this table.

R=binji@chromium.org,bradnelson@chromium.org
LOG=Y
BUG=chromium:575167
==========

to

==========
[wasm] Add support for import section.

This CL introduces an import section that names functions to be imported
as well as a CallImport bytecode to call imports from this table.

R=binji@chromium.org,bradnelson@chromium.org
LOG=Y
BUG=chromium:575167

Committed: https://crrev.com/915ae08dd5598208d6eea727ef9478a442aba290
Cr-Commit-Position: refs/heads/master@{#34157}
==========

[commit-bot: I haz the power, 2016-02-19 14:58:47]

Patchset 4 (id:??) landed as
https://crrev.com/915ae08dd5598208d6eea727ef9478a442aba290
Cr-Commit-Position: refs/heads/master@{#34157}

[binji, 2016-02-19 20:30:12]

https://codereview.chromium.org/1709653002/diff/60001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/1709653002/diff/60001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.cc:1512: wasm::FunctionSig* sig =
module_->GetFunctionSignature(index);
I think this should be GetImportSignature. I'm getting a crash in sexpr-wasm
without it.

[titzer, 2016-02-21 09:18:36]

https://codereview.chromium.org/1709653002/diff/60001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/1709653002/diff/60001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.cc:1512: wasm::FunctionSig* sig =
module_->GetFunctionSignature(index);
On 2016/02/19 20:30:12, binji wrote:
> I think this should be GetImportSignature. I'm getting a crash in sexpr-wasm
> without it.

Good catch. https://codereview.chromium.org/1717993002/