I guess we'll also need the bindings generator in a hypothetical C++ SDK.

I guess we'll also need the bindings generator in a hypothetical C++ SDK.

R=vardhan@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/06f393df6ec4f3c3fca4fb465a243bb578547e3b

[vardhan, 2016-02-17 22:31:08]

lgtm

https://codereview.chromium.org/1709643003/diff/1/sdk_build/data/cpp/cpp.sdk
File sdk_build/data/cpp/cpp.sdk (right):

https://codereview.chromium.org/1709643003/diff/1/sdk_build/data/cpp/cpp.sdk#...
sdk_build/data/cpp/cpp.sdk:25: CopyFiles("mojo/public/tools/bindings",
"third_party/mojo/tools/bindings",
do we need to include the mojo/public/third_party/jinja2 dependency, or can we
just assume the builder's system has that python library installed?

(broader question:  will this spec copy enough things to run the code generator
to completion on not-our-machines?)

[viettrungluu, 2016-02-17 22:55:54]

On 2016/02/17 22:31:08, vardhan wrote:
> lgtm
> 
> https://codereview.chromium.org/1709643003/diff/1/sdk_build/data/cpp/cpp.sdk
> File sdk_build/data/cpp/cpp.sdk (right):
> 
>
https://codereview.chromium.org/1709643003/diff/1/sdk_build/data/cpp/cpp.sdk#...
> sdk_build/data/cpp/cpp.sdk:25: CopyFiles("mojo/public/tools/bindings",
> "third_party/mojo/tools/bindings",
> do we need to include the mojo/public/third_party/jinja2 dependency, or can we
> just assume the builder's system has that python library installed?

Oops, good point. Ugh. :-/

> 
> (broader question:  will this spec copy enough things to run the code
generator
> to completion on not-our-machines?)

That's the intent, modulo assuming you have python 2.7 (and some basic packages
installed).

Well, you'll also need to fetch the mojom parser binary, but that's a separate
problem.

[viettrungluu, 2016-02-18 18:01:28]

Description was changed from

==========
I guess we'll also need the bindings generator in a hypothetical C++ SDK.

R=vardhan@google.com
==========

to

==========
I guess we'll also need the bindings generator in a hypothetical C++ SDK.

R=vardhan@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/06f393df6ec4f3c3fca4fb465a2...
==========

[viettrungluu, 2016-02-18 18:01:30]

Committed patchset #2 (id:20001) manually as
06f393df6ec4f3c3fca4fb465a243bb578547e3b (presubmit successful).