Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 1709633004: Fix a WASM compiler test failure (invalid instructions). (Closed)

Created:
4 years, 10 months ago by Alan Li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix a WASM compiler test failure (invalid instructions). WASM compiler test will sometimes generate invalid instructions for DINS/INS. BUG= Committed: https://crrev.com/4efc32ea3e931450e728596dea685fb44594d44d Cr-Commit-Position: refs/heads/master@{#34175}

Patch Set 1 #

Patch Set 2 : revert the previous patchset and add DINS in simulator. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/mips64/constants-mips64.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
akos.palfi.imgtec
lgtm
4 years, 10 months ago (2016-02-18 21:12:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709633004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709633004/20001
4 years, 10 months ago (2016-02-20 14:03:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-20 14:20:55 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-20 14:21:47 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4efc32ea3e931450e728596dea685fb44594d44d
Cr-Commit-Position: refs/heads/master@{#34175}

Powered by Google App Engine
This is Rietveld 408576698