Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 17096003: Add missing NULL check to TypeFeedbackOracle::CompareTypes() (Closed)

Created:
7 years, 6 months ago by Jakob Kummerow
Modified:
7 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev, rossberg
Visibility:
Public.

Description

Add missing NULL check to TypeFeedbackOracle::CompareTypes() R=verwaest@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15167

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/type-info.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
7 years, 6 months ago (2013-06-14 16:47:50 UTC) #1
Toon Verwaest
lgtm
7 years, 6 months ago (2013-06-14 16:50:18 UTC) #2
Jakob Kummerow
7 years, 6 months ago (2013-06-14 16:50:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15167 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698