Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 1709573003: Update dart2js CPS test expectations. (Closed)

Created:
4 years, 10 months ago by Kevin Millikin (Google)
Modified:
4 years, 10 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update dart2js CPS test expectations. corelib/data_resource_test had an expectation of RuntimeError or Crash due to overlapping test expectations. It should not crash. corelib/package_resource_test had the same expectation. It should crash. BUG= R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/fc839c713916644a346ac9439643313157a37b8c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M tests/corelib/corelib.status View 2 chunks +4 lines, -3 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
Kevin Millikin (Google)
https://codereview.chromium.org/1709573003/diff/1/tests/corelib/corelib.status File tests/corelib/corelib.status (right): https://codereview.chromium.org/1709573003/diff/1/tests/corelib/corelib.status#newcode167 tests/corelib/corelib.status:167: [ $runtime != vm && $compiler != dart2analyzer] This ...
4 years, 10 months ago (2016-02-18 09:37:20 UTC) #2
asgerf
lgtm
4 years, 10 months ago (2016-02-18 09:39:56 UTC) #3
Kevin Millikin (Google)
4 years, 10 months ago (2016-02-18 11:47:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fc839c713916644a346ac9439643313157a37b8c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698