Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1709563003: [builtins] Use JSObject::New in C++ builtins. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Use JSObject::New in C++ builtins. We already have a proper abstraction for dealing with subclassable builtins, namely JSObject::New, so we should use that instead of inlining this rather complex code sequence multiple times. R=verwaest@chromium.org Committed: https://crrev.com/528bb4b960aa2b980d5e1716bd0eebf059c131e7 Cr-Commit-Position: refs/heads/master@{#34094}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M src/builtins.cc View 2 chunks +10 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-17 17:40:10 UTC) #1
Benedikt Meurer
Hey Toon, Simple refactoring. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-02-17 17:42:33 UTC) #2
Toon Verwaest
lgtm
4 years, 10 months ago (2016-02-17 18:04:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709563003/1
4 years, 10 months ago (2016-02-17 19:55:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 19:58:32 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 19:59:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/528bb4b960aa2b980d5e1716bd0eebf059c131e7
Cr-Commit-Position: refs/heads/master@{#34094}

Powered by Google App Engine
This is Rietveld 408576698