[Swarming] Isolate gcmole.

[Swarming] Isolate gcmole.

BUG=chromium:535160
LOG=n
TBR=tandrii@chromium.org, kjellander@chromium.org

Committed: https://crrev.com/95e4c70287b2820d7c9b2aca3e9e5d65da31a04c
Cr-Commit-Position: refs/heads/master@{#34065}

[Michael Achenbach, 2016-02-17 09:40:58]

Description was changed from

==========
[Swarming] Isolate gcmole.

BUG=
==========

to

==========
[Swarming] Isolate gcmole.

BUG=chromium:535160
LOG=n
TBR=tandrii@chromium.org, kjellander@chromium.org
==========

[Michael Achenbach, 2016-02-17 09:40:58]

machenbach@chromium.org changed reviewers:
+ andrii@chromium.org, kjellander@chromium.org

[Michael Achenbach, 2016-02-17 09:42:02]

machenbach@chromium.org changed reviewers:
+ tandrii@chromium.org
- andrii@chromium.org

[Michael Achenbach, 2016-02-17 09:42:02]

PTAL

[Michael Achenbach, 2016-02-17 09:42:11]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 09:42:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1709503002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1709503002/1

[tandrii(chromium), 2016-02-17 09:49:28]

LGTM

[Michael Achenbach, 2016-02-17 09:53:07]

The CQ bit was unchecked by machenbach@chromium.org

[Michael Achenbach, 2016-02-17 09:53:12]

The CQ bit was checked by machenbach@chromium.org

[kjellander_chromium, 2016-02-17 09:53:14]

https://codereview.chromium.org/1709503002/diff/1/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/1709503002/diff/1/build/standalone.gypi#newco...
build/standalone.gypi:383: 'gcmole%': 0,
It's not obvious by the name. What about has_gcmole instead (similar to
has_valgrind)?

Is it going to be set to 1 in the buildbot recipe?

[commit-bot: I haz the power, 2016-02-17 09:53:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1709503002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1709503002/1

[Michael Achenbach, 2016-02-17 09:58:03]

https://codereview.chromium.org/1709503002/diff/1/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/1709503002/diff/1/build/standalone.gypi#newco...
build/standalone.gypi:383: 'gcmole%': 0,
On 2016/02/17 09:53:14, kjellander (chromium) wrote:
> It's not obvious by the name. What about has_gcmole instead (similar to
> has_valgrind)?
> 
> Is it going to be set to 1 in the buildbot recipe?

It already is here:
https://codereview.chromium.org/1704893002/

I'm not sure about a name change. has_valgrind has the semantics: check if
valgrind is already there (downloaded as custom deps). gcmole has the semantics:
Please download gcmole (here as a hook). There's a difference.

[commit-bot: I haz the power, 2016-02-17 10:08:04]

Description was changed from

==========
[Swarming] Isolate gcmole.

BUG=chromium:535160
LOG=n
TBR=tandrii@chromium.org, kjellander@chromium.org
==========

to

==========
[Swarming] Isolate gcmole.

BUG=chromium:535160
LOG=n
TBR=tandrii@chromium.org, kjellander@chromium.org
==========

[commit-bot: I haz the power, 2016-02-17 10:08:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-17 10:08:12]

Description was changed from

==========
[Swarming] Isolate gcmole.

BUG=chromium:535160
LOG=n
TBR=tandrii@chromium.org, kjellander@chromium.org
==========

to

==========
[Swarming] Isolate gcmole.

BUG=chromium:535160
LOG=n
TBR=tandrii@chromium.org, kjellander@chromium.org

Committed: https://crrev.com/95e4c70287b2820d7c9b2aca3e9e5d65da31a04c
Cr-Commit-Position: refs/heads/master@{#34065}
==========

[commit-bot: I haz the power, 2016-02-17 10:08:12]

Patchset 1 (id:??) landed as
https://crrev.com/95e4c70287b2820d7c9b2aca3e9e5d65da31a04c
Cr-Commit-Position: refs/heads/master@{#34065}