Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: ui/gfx/mac/io_surface.cc

Issue 1709443002: Clear IOSurfaces immediately after creating them. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix flag. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/gl/test/gl_image_test_template.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/gfx/mac/io_surface.h" 5 #include "ui/gfx/mac/io_surface.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 AddIntegerValue(properties, kIOSurfaceWidth, size.width()); 141 AddIntegerValue(properties, kIOSurfaceWidth, size.width());
142 AddIntegerValue(properties, kIOSurfaceHeight, size.height()); 142 AddIntegerValue(properties, kIOSurfaceHeight, size.height());
143 AddIntegerValue(properties, kIOSurfacePixelFormat, PixelFormat(format)); 143 AddIntegerValue(properties, kIOSurfacePixelFormat, PixelFormat(format));
144 if (num_planes > 1) { 144 if (num_planes > 1) {
145 CFDictionaryAddValue(properties, kIOSurfacePlaneInfo, planes); 145 CFDictionaryAddValue(properties, kIOSurfacePlaneInfo, planes);
146 } else { 146 } else {
147 AddIntegerValue(properties, kIOSurfaceBytesPerElement, 147 AddIntegerValue(properties, kIOSurfaceBytesPerElement,
148 BytesPerElement(format, 0)); 148 BytesPerElement(format, 0));
149 } 149 }
150 150
151 return IOSurfaceCreate(properties); 151 IOSurfaceRef surface = IOSurfaceCreate(properties);
152
153 // Zero-initialize the texture. Calling IOSurfaceLock/IOSurfaceUnlock appears
reveman 2016/02/17 19:21:51 nit: s/texture/IOSurface/
erikchen 2016/02/17 19:23:55 Done.
154 // to be sufficient.
155 // https://code.google.com/p/chromium/issues/detail?id=584760#c17
156 IOReturn r = IOSurfaceLock(surface, 0, nullptr);
157 DCHECK_EQ(kIOReturnSuccess, r);
158 r = IOSurfaceUnlock(surface, 0, nullptr);
159 DCHECK_EQ(kIOReturnSuccess, r);
160
161 return surface;
152 } 162 }
153 163
154 } // namespace gfx 164 } // namespace gfx
OLDNEW
« no previous file with comments | « no previous file | ui/gl/test/gl_image_test_template.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698