Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1709413003: MD Settings: polish up some top-level buttons (Closed)

Created:
4 years, 10 months ago by Dan Beam
Modified:
4 years, 10 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: polish up some top-level buttons This removes text-transform none that undoes capitalization. Yes, this does expose some oddities for rows that are implemented as <paper-button> <div> <div class="secondary> I think we should implement those instead with: <paper-ripple> <div> <div class="secondary"> But it depends on the desired focus behavior. In general, we should be using <paper-button> when the mocks are ALL UPPER, and <a href> for lowercase links and <a is="action-link"> for lowercased links that dont actually go anywhere (i.e. "Add a search engine") R=dschuyler@chromium.org BUG=425627 Committed: https://crrev.com/28167989a78878b282fdd4a882ec8a5c16ced975 Cr-Commit-Position: refs/heads/master@{#377153}

Patch Set 1 : secondary #

Patch Set 2 : merge #

Patch Set 3 : fixes #

Patch Set 4 : id #

Patch Set 5 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -23 lines) Patch
M chrome/browser/resources/settings/people_page/people_page.html View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engines_page.html View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/search_page/search_page.html View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 1 2 5 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Dan Beam
http://imgur.com/a/6w8pM
4 years, 10 months ago (2016-02-20 00:14:12 UTC) #3
Dan Beam
ping
4 years, 10 months ago (2016-02-23 02:51:48 UTC) #4
dschuyler
lgtm
4 years, 10 months ago (2016-02-23 21:24:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709413003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709413003/80001
4 years, 10 months ago (2016-02-23 22:22:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/26000) android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, ...
4 years, 10 months ago (2016-02-23 22:41:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709413003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709413003/100001
4 years, 10 months ago (2016-02-24 00:05:57 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 10 months ago (2016-02-24 00:44:30 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 00:46:00 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/28167989a78878b282fdd4a882ec8a5c16ced975
Cr-Commit-Position: refs/heads/master@{#377153}

Powered by Google App Engine
This is Rietveld 408576698