Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: ppapi/tests/test_network_proxy.cc

Issue 17094022: PPAPI: Add permissions checking for PPB_NetworkProxy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge, appease Clang Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/pepper/pepper_network_proxy_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_network_proxy.cc
diff --git a/ppapi/tests/test_network_proxy.cc b/ppapi/tests/test_network_proxy.cc
index 4eb41498f6d33d4df408169f47b32aeb8fe81e62..c372985819d2aa5f81f8c6eeb3d5ab441a090c10 100644
--- a/ppapi/tests/test_network_proxy.cc
+++ b/ppapi/tests/test_network_proxy.cc
@@ -59,7 +59,6 @@ std::string TestNetworkProxy::TestGetProxyForURL() {
pp::Var("this isn't a url"),
callback.GetCallback()));
CHECK_CALLBACK_BEHAVIOR(callback);
- // TODO(dmichael): Use bad address when it's available.
ASSERT_EQ(PP_ERROR_BADARGUMENT, callback.result());
// TODO(dmichael): Add this check below when crbug.com/250046 is fixed.
// ASSERT_TRUE(callback.output().is_undefined());
« no previous file with comments | « content/browser/renderer_host/pepper/pepper_network_proxy_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698