ppapi/tests/test_network_proxy.cc - Issue 17094022: PPAPI: Add permissions checking for PPB_NetworkProxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/tests/test_network_proxy.cc

Issue 17094022: PPAPI: Add permissions checking for PPB_NetworkProxy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/tests/test_network_proxy.cc

diff --git a/ppapi/tests/test_network_proxy.cc b/ppapi/tests/test_network_proxy.cc

index 4eb41498f6d33d4df408169f47b32aeb8fe81e62..0657e7610b86d1226caf1e2fcf15589f6657a63e 100644

--- a/ppapi/tests/test_network_proxy.cc

+++ b/ppapi/tests/test_network_proxy.cc

@@ -59,8 +59,7 @@ std::string TestNetworkProxy::TestGetProxyForURL() {

pp::Var("this isn't a url"),

callback.GetCallback()));

CHECK_CALLBACK_BEHAVIOR(callback);

- // TODO(dmichael): Use bad address when it's available.

- ASSERT_EQ(PP_ERROR_BADARGUMENT, callback.result());

+ ASSERT_EQ(PP_ERROR_ADDRESS_INVALID, callback.result());

// TODO(dmichael): Add this check below when crbug.com/250046 is fixed.

// ASSERT_TRUE(callback.output().is_undefined());