Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 17094011: Include WiFi.FrequencyList in NetworkState (Closed)

Created:
7 years, 6 months ago by stevenjb
Modified:
7 years, 6 months ago
CC:
chromium-reviews, gauravsh+watch_chromium.org, gspencer+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use shill constant #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -5 lines) Patch
M chromeos/network/network_state.h View 3 chunks +5 lines, -1 line 0 comments Download
M chromeos/network/network_state.cc View 1 6 chunks +32 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
stevenjb
https://codereview.chromium.org/17094011/diff/1/chromeos/network/network_state.cc File chromeos/network/network_state.cc (right): https://codereview.chromium.org/17094011/diff/1/chromeos/network/network_state.cc#newcode20 chromeos/network/network_state.cc:20: const char kWifiFrequencyListProperty[] = "WiFi.FrequencyList"; This will be removed ...
7 years, 6 months ago (2013-06-20 20:19:29 UTC) #1
Greg Spencer (Chromium)
lgtm
7 years, 6 months ago (2013-06-20 20:25:52 UTC) #2
stevenjb
7 years, 6 months ago (2013-06-21 18:36:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r207888 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698