Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 17094005: Fix MathFloorOfDiv canonicalization ASSERT failures (Closed)

Created:
7 years, 6 months ago by Jakob Kummerow
Modified:
7 years, 6 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Fix MathFloorOfDiv canonicalization ASSERT failures - remove outdated ASSERT about instruction type - add inserted HChanges to the graph R=danno@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M src/hydrogen-instructions.cc View 4 chunks +11 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
7 years, 6 months ago (2013-06-14 16:21:04 UTC) #1
danno
lgtm
7 years, 6 months ago (2013-06-14 16:24:04 UTC) #2
Jakob Kummerow
7 years, 6 months ago (2013-06-14 16:28:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15166 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698