runtime/vm/object.cc - Issue 1709383002: Improve behaviour when we hit a stack overflow / OOM error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 1709383002: Improve behaviour when we hit a stack overflow / OOM error (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index 93f2818be2c00f6f948d0d9afdcc0d3d6ec9ae39..bf784d2b1d7da5921e2306076a1d0da7c5b3118f 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -21089,6 +21089,9 @@ const char* Stacktrace::ToCStringInternal(intptr_t* frame_index,

OS::SNPrint(chars, truncated_len, "%s", kTruncated);

frame_strings.Add(chars);

total_len += truncated_len;

+ ASSERT(PcOffsetAtFrame(i) != Smi::null());

+ // To account for gap frames.

+ (*frame_index) += Smi::Value(PcOffsetAtFrame(i));

}

} else {

code = CodeAtFrame(i);

« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »