Improve behaviour when we hit a stack overflow / OOM error

Improve behaviour when we hit a stack overflow / OOM error

Fixes #25815

VM changes:

- Don't crash in SignalExceptionThrown when we have no stack frames.

- Notify the debugger about an unhandled stack overflow / OOM *after* setting the sticky error. This allows Observatory to display it.

- When pausing without a debugger attached, print the sticky error if one is set.

- Improve stack trace frame numbers when printing for a stack overflow.

Observatory changes:

- Report the sticky error for pause at unhandled exception as well as exit.

- Let the user know that we cannot pause for unhandled stack overflow / OOM exceptions.

- Don't show the "at <func> (<script location>)" string in the isolate summary, if we don't have a top frame.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/b482480b65214babf4e2a332eca5f23a3324001c

[Cutch, 2016-02-19 01:06:37]

Description was changed from

==========
Improve behaviour when we hit a stack overflow / OOM error

BUG=
==========

to

==========
Improve behaviour when we hit a stack overflow / OOM error

Fixes #25815

VM changes:

- Don't crash in SignalExceptionThrown when we have no stack frames.

- Don't pause for an unhandled stack overflow / OOM exception if we are going to
pause at exit.

- Notify the debugger about an unhandled stack overflow / OOM *after* setting
the sticky error. This allows Observatory to display it.

- When pausing without a debugger attached, print the sticky error if one is
set.


Observatory changes:

- Report the sticky error for pause at unhandled exception as well as exit.

- Let the user know that we cannot pause for unhandled stack overflow / OOM
exceptions.

- Don't show the "at <func> (<script location>)" string in the isolate summary,
if we don't have a top frame.
==========

[Cutch, 2016-02-19 01:06:37]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[Cutch, 2016-02-19 01:29:13]

Description was changed from

==========
Improve behaviour when we hit a stack overflow / OOM error

Fixes #25815

VM changes:

- Don't crash in SignalExceptionThrown when we have no stack frames.

- Don't pause for an unhandled stack overflow / OOM exception if we are going to
pause at exit.

- Notify the debugger about an unhandled stack overflow / OOM *after* setting
the sticky error. This allows Observatory to display it.

- When pausing without a debugger attached, print the sticky error if one is
set.


Observatory changes:

- Report the sticky error for pause at unhandled exception as well as exit.

- Let the user know that we cannot pause for unhandled stack overflow / OOM
exceptions.

- Don't show the "at <func> (<script location>)" string in the isolate summary,
if we don't have a top frame.
==========

to

==========
Improve behaviour when we hit a stack overflow / OOM error

Fixes #25815

VM changes:

- Don't crash in SignalExceptionThrown when we have no stack frames.

- Notify the debugger about an unhandled stack overflow / OOM *after* setting
the sticky error. This allows Observatory to display it.

- When pausing without a debugger attached, print the sticky error if one is
set.


Observatory changes:

- Report the sticky error for pause at unhandled exception as well as exit.

- Let the user know that we cannot pause for unhandled stack overflow / OOM
exceptions.

- Don't show the "at <func> (<script location>)" string in the isolate summary,
if we don't have a top frame.
==========

[rmacnak, 2016-02-22 17:55:27]

lgtm w/c

https://chromiumcodereview.appspot.com/1709383002/diff/20001/runtime/observat...
File runtime/observatory/lib/src/elements/debugger.dart (right):

https://chromiumcodereview.appspot.com/1709383002/diff/20001/runtime/observat...
runtime/observatory/lib/src/elements/debugger.dart:1514: 'memory therefor the
isolate cannot be paused.');
therefore

https://chromiumcodereview.appspot.com/1709383002/diff/20001/runtime/observat...
File runtime/observatory/lib/src/service/object.dart (right):

https://chromiumcodereview.appspot.com/1709383002/diff/20001/runtime/observat...
runtime/observatory/lib/src/service/object.dart:2328: bool get
isStackOverflowError => clazz.name == 'StackOverflowError';
And library is dart:core.

[Cutch, 2016-02-22 18:37:50]

Description was changed from

==========
Improve behaviour when we hit a stack overflow / OOM error

Fixes #25815

VM changes:

- Don't crash in SignalExceptionThrown when we have no stack frames.

- Notify the debugger about an unhandled stack overflow / OOM *after* setting
the sticky error. This allows Observatory to display it.

- When pausing without a debugger attached, print the sticky error if one is
set.


Observatory changes:

- Report the sticky error for pause at unhandled exception as well as exit.

- Let the user know that we cannot pause for unhandled stack overflow / OOM
exceptions.

- Don't show the "at <func> (<script location>)" string in the isolate summary,
if we don't have a top frame.
==========

to

==========
Improve behaviour when we hit a stack overflow / OOM error

Fixes #25815

VM changes:

- Don't crash in SignalExceptionThrown when we have no stack frames.

- Notify the debugger about an unhandled stack overflow / OOM *after* setting
the sticky error. This allows Observatory to display it.

- When pausing without a debugger attached, print the sticky error if one is
set.

- Improve stack trace frame numbers when printing for a stack overflow.

Observatory changes:

- Report the sticky error for pause at unhandled exception as well as exit.

- Let the user know that we cannot pause for unhandled stack overflow / OOM
exceptions.

- Don't show the "at <func> (<script location>)" string in the isolate summary,
if we don't have a top frame.
==========

[Cutch, 2016-02-22 18:38:17]

+ Improve stack trace frame numbers when printing for a stack overflow.

PTAL

https://codereview.chromium.org/1709383002/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/debugger.dart (right):

https://codereview.chromium.org/1709383002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/debugger.dart:1514: 'memory therefor the
isolate cannot be paused.');
On 2016/02/22 17:55:27, rmacnak wrote:
> therefore

Done.

https://codereview.chromium.org/1709383002/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/1709383002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:2328: bool get
isStackOverflowError => clazz.name == 'StackOverflowError';
On 2016/02/22 17:55:27, rmacnak wrote:
> And library is dart:core.

Done.

[rmacnak, 2016-02-22 18:59:12]

lgtm w/nit

https://codereview.chromium.org/1709383002/diff/40001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1709383002/diff/40001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:21082: // Check if null function object indicates a gap in
a StackOverflow or
Check for a null function, which indicates a gap...

[Cutch, 2016-02-22 19:01:00]

https://codereview.chromium.org/1709383002/diff/40001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1709383002/diff/40001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:21082: // Check if null function object indicates a gap in
a StackOverflow or
On 2016/02/22 18:59:12, rmacnak wrote:
> Check for a null function, which indicates a gap...

Done.

[Cutch, 2016-02-25 15:33:06]

Description was changed from

==========
Improve behaviour when we hit a stack overflow / OOM error

Fixes #25815

VM changes:

- Don't crash in SignalExceptionThrown when we have no stack frames.

- Notify the debugger about an unhandled stack overflow / OOM *after* setting
the sticky error. This allows Observatory to display it.

- When pausing without a debugger attached, print the sticky error if one is
set.

- Improve stack trace frame numbers when printing for a stack overflow.

Observatory changes:

- Report the sticky error for pause at unhandled exception as well as exit.

- Let the user know that we cannot pause for unhandled stack overflow / OOM
exceptions.

- Don't show the "at <func> (<script location>)" string in the isolate summary,
if we don't have a top frame.
==========

to

==========
Improve behaviour when we hit a stack overflow / OOM error

Fixes #25815

VM changes:

- Don't crash in SignalExceptionThrown when we have no stack frames.

- Notify the debugger about an unhandled stack overflow / OOM *after* setting
the sticky error. This allows Observatory to display it.

- When pausing without a debugger attached, print the sticky error if one is
set.

- Improve stack trace frame numbers when printing for a stack overflow.

Observatory changes:

- Report the sticky error for pause at unhandled exception as well as exit.

- Let the user know that we cannot pause for unhandled stack overflow / OOM
exceptions.

- Don't show the "at <func> (<script location>)" string in the isolate summary,
if we don't have a top frame.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b482480b65214babf4e2a332eca5f23a3324001c
==========

[Cutch, 2016-02-25 15:33:08]

Committed patchset #4 (id:60001) manually as
b482480b65214babf4e2a332eca5f23a3324001c (presubmit successful).